From 33efbc9013dad503ee69f1ea5532a82209940ebf Mon Sep 17 00:00:00 2001 From: Rebecca McGinn Date: Fri, 4 Nov 2022 17:07:48 +0000 Subject: [PATCH 1/3] Add duration to fixture data --- data/mundo/topics/c1en6xwmpkvt.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/data/mundo/topics/c1en6xwmpkvt.json b/data/mundo/topics/c1en6xwmpkvt.json index a9268cd83d1..9a678691a38 100644 --- a/data/mundo/topics/c1en6xwmpkvt.json +++ b/data/mundo/topics/c1en6xwmpkvt.json @@ -66,6 +66,7 @@ { "title": "El video de prueba", "type": "video", + "duration": "PT5M", "firstPublished": "2022-05-12T10:41:21.000Z", "link": "https://www.bbc.com/mundo/23048701", "imageUrl": "https://ichef.test.bbci.co.uk/news/{width}/cpsdevpb/FA0D/test/_63931046_p00wjk8v.jpg", @@ -76,6 +77,7 @@ { "title": "Anuncio del acuerdo", "type": "video", + "duration": "PT5M", "firstPublished": "2022-05-12T10:41:14.000Z", "link": "https://www.bbc.com/mundo/noticias-internacional-23452772", "imageUrl": "https://ichef.test.bbci.co.uk/news/{width}/cpsdevpb/ABED/test/_63931044_p0182w7g.jpg", @@ -86,6 +88,7 @@ { "title": "Hippopotamos tomando el sol", "type": "video", + "duration": "PT5M", "firstPublished": "2022-05-12T10:41:02.000Z", "link": "https://www.bbc.com/mundo/noticias-america-latina-23049956", "imageUrl": "https://ichef.test.bbci.co.uk/news/{width}/cpsdevpb/1482D/test/_63931048_p012z4jy.jpg", From 8203c68c9ac3b49735b2599d64f4943400f3ca07 Mon Sep 17 00:00:00 2001 From: Rebecca McGinn Date: Fri, 4 Nov 2022 17:11:05 +0000 Subject: [PATCH 2/3] Correct property is duration, not mediaDuration --- src/app/pages/TopicPage/Curation/CurationPromo/index.jsx | 6 +++--- .../TopicPage/Curation/CurationPromo/index.stories.jsx | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/pages/TopicPage/Curation/CurationPromo/index.jsx b/src/app/pages/TopicPage/Curation/CurationPromo/index.jsx index 830f8ab374c..0f247081fb0 100644 --- a/src/app/pages/TopicPage/Curation/CurationPromo/index.jsx +++ b/src/app/pages/TopicPage/Curation/CurationPromo/index.jsx @@ -11,7 +11,7 @@ const CurationPromo = ({ lazy, link, type, - mediaDuration, + duration: mediaDuration, headingLevel, }) => { return ( @@ -36,14 +36,14 @@ CurationPromo.propTypes = { lazy: bool, link: string.isRequired, type: string, - mediaDuration: number, + duration: number, headingLevel: number, }; CurationPromo.defaultProps = { lazy: false, type: null, - mediaDuration: null, + duration: null, headingLevel: 2, }; diff --git a/src/app/pages/TopicPage/Curation/CurationPromo/index.stories.jsx b/src/app/pages/TopicPage/Curation/CurationPromo/index.stories.jsx index d47e88ee262..59a307f52c9 100644 --- a/src/app/pages/TopicPage/Curation/CurationPromo/index.stories.jsx +++ b/src/app/pages/TopicPage/Curation/CurationPromo/index.stories.jsx @@ -34,7 +34,7 @@ const WithMediaIndicator = ({ service, variant }) => { From 5a52f67ab2c89c680d658f59fe78f30d5361fb8d Mon Sep 17 00:00:00 2001 From: Rebecca McGinn Date: Wed, 9 Nov 2022 15:36:14 +0000 Subject: [PATCH 3/3] mediaDuration -> duration for HierPromo --- src/app/pages/TopicPage/HierarchicalGrid/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/pages/TopicPage/HierarchicalGrid/index.tsx b/src/app/pages/TopicPage/HierarchicalGrid/index.tsx index 0a0203ea017..34ebdcd4b14 100644 --- a/src/app/pages/TopicPage/HierarchicalGrid/index.tsx +++ b/src/app/pages/TopicPage/HierarchicalGrid/index.tsx @@ -12,7 +12,7 @@ type Summary = { id: string; link?: string; firstPublished?: string | number; - mediaDuration?: string | number; + duration?: string | number; imageUrl?: string; imageAlt?: string; mediaType?: 'audio' | 'video' | 'photogallery'; @@ -60,7 +60,7 @@ const HiearchicalGrid = ({ summaries }: Summaries) => { loading="lazy" > - {promo.mediaDuration} + {promo.duration}