Skip to content

Commit ee97fbb

Browse files
committed
adds compatability for VM disk size in NetBox 4.1.0 #413
1 parent 9b1aeb8 commit ee97fbb

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

module/sources/vmware/connection.py

+10-6
Original file line numberDiff line numberDiff line change
@@ -2261,15 +2261,19 @@ def add_virtual_machine(self, obj):
22612261
if grab(vm_device_backing, "fileName") is not None:
22622262
vm_device_description.append(grab(vm_device_backing, "fileName"))
22632263

2264-
disk_size = grab(vm_device, "capacityInKB", fallback=0)
2265-
disk_size_in_gb = int(disk_size / 1024 / 1024)
2266-
if disk_size_in_gb < 1:
2267-
vm_device_description.append(f"Size: {int(disk_size / 1024)} MB")
2268-
disk_size_in_gb = 1
2264+
disk_size_in_kb = grab(vm_device, "capacityInKB", fallback=0)
2265+
if version.parse(self.inventory.netbox_api_version) < version.parse("4.1.0"):
2266+
disk_size = int(disk_size_in_kb / 1024 / 1024)
2267+
if disk_size < 1:
2268+
vm_device_description.append(f"Size: {int(disk_size_in_kb / 1024)} MB")
2269+
disk_size = 1
2270+
# since NetBox 4.1.0 disk size is represented in MB
2271+
else:
2272+
disk_size = int(disk_size_in_kb / 1024)
22692273

22702274
disk_data.append({
22712275
"name": grab(vm_device, "deviceInfo.label"),
2272-
"size": disk_size_in_gb,
2276+
"size": disk_size,
22732277
"description": " / ".join(vm_device_description)
22742278
})
22752279

0 commit comments

Comments
 (0)