Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine path forward to remove or further embrace xcconfig #245

Open
jerrymarino opened this issue Aug 19, 2020 · 0 comments
Open

Determine path forward to remove or further embrace xcconfig #245

jerrymarino opened this issue Aug 19, 2020 · 0 comments

Comments

@jerrymarino
Copy link
Collaborator

The original usage and unfortunate linage of xcconfig for diagnostics is documented on github:
https://github.com/pinterest/xchammer/blob/master/Docs/FastAndReproducibleBuildsWithXCHammer.md#diagnostics

We're stuck with this because there isn't a great way to turn off default flags in Xcode without xcconfig.

Therefore, we use xcconfig to sync up Xcode with Bazel. When we migrated to Bazel we generated .bzl files to represent xcconfig. Today, we manually sync up xcconfig and .bzl when the diags change.

The program mentioned in the doc is included with xchammer now and devs have used this in the past when they refactored diagnostic settings. These diagnostic settings don't often have a reason to change

tools/XCConfigExporter:xcconfig-exporter

Ideally, we can have a solution to disable defaults and sidestep this problem without significant runtime patches. Otherwise, I image an xcconfig evaluator could be integrated as a repository rule or toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant