Fails for Windows ARM64 GitHub runners

[jxy-s]

According to the following job it appears that setup-bazel is not functioning when using Windows ARM64 GitHub runners:
https://github.com/archonitelabs/radiant-cpp/actions/runs/9359175843/job/25800924517

See also:
https://github.blog/2024-06-03-arm64-on-github-actions-powering-faster-more-efficient-build-systems/

[jxy-s]

The workflow is using an older version, bazel-contrib/setup-bazel@0.8.2 - forgive me if this is already fixed. I can retest with the latest version in a bit.

[jxy-s]

Confirmed running with latest version shows the same issue: https://github.com/archonitelabs/radiant-cpp/actions/runs/9371722658/job/25801604485?pr=18

For posterity, the extra slash here is necessary: bazel test --test_output=all ///... - the non-ARM64 one works fine, and this is necessary to work around an idiosyncrasy with PowerShell on windows:

https://github.com/archonitelabs/radiant-cpp/blob/a9fa01fcd620944bb2052448797594c7697bb5bd/.github/workflows/unit-tests.yaml#L54-L83

[jxy-s]

Here is a run with debugging enabled: https://github.com/archonitelabs/radiant-cpp/actions/runs/9371722658/job/25801888908

[p0deje]

@jxy-s Your test fails with Error: bash: command not found - it doesn't seem to be related to setup-bazel.

[jxy-s]

🤔 I see, I guess I easily overlooked that since the other non-ARM windows machine worked with it. Let me try an alternative.

[jxy-s]

Okay so using cmd instead of bash shows: https://github.com/archonitelabs/radiant-cpp/actions/runs/9372646381/job/25804580277?pr=18

Run bazel test --test_output=all //...
'bazel' is not recognized as an internal or external command,
operable program or batch file.
Error: Process completed with exit code 1.

[p0deje]

That's because there is no Bazel installed on GitHub runner, even though it's pre-installed on Windows X64. If you want for the action to install one for you, you need to pass bazelisk-version: 1x input.

[jxy-s]

https://github.com/archonitelabs/radiant-cpp/actions/runs/9372804523/job/25805096299?pr=18

  Error: Error: Unable to find Bazelisk version 1.x for platform windows/arm64
      at downloadBazelisk (C:\a\_actions\bazel-contrib\setup-bazel\0.8.5\dist\index.js:90:1)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at setupBazelisk (C:\a\_actions\bazel-contrib\setup-bazel\0.8.5\dist\index.js:43:1)
      at setupBazel (C:\a\_actions\bazel-contrib\setup-bazel\0.8.5\dist\index.js:26:1)
      at run (C:\a\_actions\bazel-contrib\setup-bazel\0.8.5\dist\index.js:12:1)

I tried also with 1.20.0 instead of 1.x.
https://github.com/archonitelabs/radiant-cpp/actions/runs/9372780009/job/25805012776

  Error: Error: Unable to find Bazelisk version 1.20.0 for platform windows/arm64
      at downloadBazelisk (C:\a\_actions\bazel-contrib\setup-bazel\0.8.5\dist\index.js:90:1)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at setupBazelisk (C:\a\_actions\bazel-contrib\setup-bazel\0.8.5\dist\index.js:43:1)
      at setupBazel (C:\a\_actions\bazel-contrib\setup-bazel\0.8.5\dist\index.js:26:1)
      at run (C:\a\_actions\bazel-contrib\setup-bazel\0.8.5\dist\index.js:12:1)

@p0deje could this be related to?: bazelbuild/bazelisk#572

[p0deje]

Yes, it's related to this issue. If Bazelisk ships a native ARM64 binary, it would work out-of-the-box with setup-bazel.
We could work it around for now by forcing x64 architecture on Windows.

[jxy-s]

The drawback of forcing x64 bazelisk on Windows is that bazel won't use the right toolchain and will compile non-native x64 on ARM64, which is not desired. I think the best course of action is to resolve it in the bazelisk repo and produce an ARM64 binary for Windows.

[p0deje]

The drawback of forcing x64 bazelisk on Windows is that bazel won't use the right toolchain and will compile non-native x64 on ARM64, which is not desired. I think the best course of action is to resolve it in the bazelisk repo and produce an ARM64 binary for Windows.

Actually Bazel would still download proper toolchains and compilation should work correctly. I agree that it should be fixed upstream, but in the mean time - can you test p0deje/fix-windows-arm64 branch and let me know if it helps?

[jxy-s]

I am testing, but I'm confident that this is not going to do what is desired. Windows ARM64 using non-native bazel will build an x64 binary. In the case of a testing workflow that is very much undesired. You want to build and run tests on a native platform. I'll collect data and report back.

I suggest not merging #28 until we've come to a consensus here.

For reference: bazelbuild/bazel#22164 (comment) and bazelbuild/bazelisk#572

[jxy-s]

It seems like it's still broken for another reason? Looks like bazelisk-version: 1.x here is succeeding but the command can't locate the newly installed bazelisk? I tried specifying both bazel and bazelisk without luck.

https://github.com/archonitelabs/radiant-cpp/actions/runs/9451455948/job/26032443902#step:4:5

https://github.com/archonitelabs/radiant-cpp/actions/runs/9451414740/job/26032294653?pr=19#step:4:5

[p0deje]

Yes, I think there is an issue with how file is added to the tool cache, let me try to prepare another version.