Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake copy wrong files to folder EXT_BUILD_DEPS #1205

Open
fausturs opened this issue May 24, 2024 · 0 comments
Open

cmake copy wrong files to folder EXT_BUILD_DEPS #1205

fausturs opened this issue May 24, 2024 · 0 comments

Comments

@fausturs
Copy link

I'm using the cmake tool to build my cmake project with bazel.

one of my deps is glog/0.5.0

I find rules_foreign_cc copy all .h files of glog to folder EXT_BUILD_DEPS/include.

As we can see the glog project https://github.com/google/glog/blob/v0.5.0/bazel/glog.bzl#L140-L147

we only need EXT_BUILD_DEPS/include/glog/xxx.h

But actually, we get all headers even it declare in the filed srcs, like EXT_BUILD_DEPS/include/demangle.h, it's src/demangle.h in glog, declare in https://github.com/google/glog/blob/v0.5.0/bazel/glog.bzl#L120

This caused some conflicts in our header files.

Is this behavior expected, or are there ways we can avoid unnecessary copies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant