Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settle on a docstring format and update all docstrings #427

Closed
10 tasks done
bwheelz36 opened this issue May 16, 2023 · 5 comments · Fixed by #457
Closed
10 tasks done

settle on a docstring format and update all docstrings #427

bwheelz36 opened this issue May 16, 2023 · 5 comments · Fixed by #457

Comments

@bwheelz36
Copy link
Collaborator

bwheelz36 commented May 16, 2023

@bwheelz36
Copy link
Collaborator Author

this will probably be helpful too:
https://github.com/dadadel/pyment

@till-m
Copy link
Member

till-m commented May 22, 2023

numpy format

That would be according to this, I assume? If yes, that looks good to me!

@till-m
Copy link
Member

till-m commented Jun 27, 2023

(moved todo's to top post)

@till-m
Copy link
Member

till-m commented Jul 5, 2023

I have started doing some work on this. I also ran pylint over the codebase in parallel and started fixing some of code smells it reports. Since this is a rather large undertaking I would suggest proceeding in the following way:

  • We fork the main branch to a separate branch in this project called something along the lines of docstring-overhaul or similar.
  • We successively process the docstrings of each file and after finishing 1-3 files open a pull request to the docstring-overhaul branch
  • After all files have been processed, we merge the docstring-overhaul branch into master.

This will make the entire thing more granular and not result in a 4000 lines PR that needs to be reviewed. Any thoughts or objections?

@bwheelz36
Copy link
Collaborator Author

Great work.
Honestly, not sure how much I will be able to help. I'm pretty busy with my new job. However the process sounds good :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants