-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settle on a docstring format and update all docstrings #427
Comments
this will probably be helpful too: |
That would be according to this, I assume? If yes, that looks good to me! |
(moved todo's to top post) |
I have started doing some work on this. I also ran pylint over the codebase in parallel and started fixing some of code smells it reports. Since this is a rather large undertaking I would suggest proceeding in the following way:
This will make the entire thing more granular and not result in a 4000 lines PR that needs to be reviewed. Any thoughts or objections? |
Great work. |
As discussed in #425.
Suggest using the numpy format, and integrating pydocstyle into test framework
TODO:
constraint.py
Update docs & linting forconstraints.py
,target_space.py
#440logger.py
Replace custom colour implementation, add docs forlogger.py
,util.py
#435util.py
Replace custom colour implementation, add docs forlogger.py
,util.py
#435domain_reduction.py
bounds_transformer could bypass global_bounds due to the test logic within _trim function in domain_reduction.py #441observer.py
Update various docstrings, add workflow to check docstrings #445bayesian_optimization.py
Update various docstrings, add workflow to check docstrings #445event.py
Update various docstrings, add workflow to check docstrings #445target_space.py
Update docs & linting forconstraints.py
,target_space.py
#440pydocstyle
into testing. Update various docstrings, add workflow to check docstrings #445numpydoc
The text was updated successfully, but these errors were encountered: