Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace CSS Selectors #5

Open
moahmed opened this issue Apr 19, 2014 · 1 comment
Open

Namespace CSS Selectors #5

moahmed opened this issue Apr 19, 2014 · 1 comment

Comments

@moahmed
Copy link
Collaborator

moahmed commented Apr 19, 2014

Confine the css with the elements inside the rbox.

For example:
.nextLightBox, .prevLightBox, .closeLightBox {
color: #777;
}
Should ideally apply this only to elements in the scope for rbox
.container .nextLightBox,
.container .prevLightBox,
.container .closeLightBox {
color: #777;
}
So if by chance anyboy has a selector by this name on his page it will not be affected.

Also applying css of global selectors is not needed.
For example:

  • {
    -webkit-box-sizing: border-box;
    -moz-box-sizing: border-box;
    box-sizing: border-box;
    }
    Anybody who uses this plugin will get box-sizing: border-box; with knowing about it also.

Not sure why we want to change the color of body element also
body {
color: #222;
}

@batpad
Copy link
Owner

batpad commented May 2, 2014

@imohkay , could you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants