Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea for enhancing manual control #237

Closed
broyuken opened this issue Dec 20, 2021 · 15 comments · May be fixed by #512
Closed

Idea for enhancing manual control #237

broyuken opened this issue Dec 20, 2021 · 15 comments · May be fixed by #512

Comments

@broyuken
Copy link

This is to hopefully resolve the by far #1 complaint my wife has with our smart home. When she turns on a light, AL adjusts it to what it thinks it should be, she changes it to what she wants it to be, then AL adjusts it back.

Could you add a check in after the initial turn on transition for the light? If the light is where AL thinks it should be, great. If it's not, set it to manually controlled and stop adjusting it.

@vbaros
Copy link

vbaros commented Dec 20, 2021

There is an option take over control which does exactly that.

@broyuken
Copy link
Author

It doesn’t though. If I turn it on and immediately change the brightness like a normal person would AL still takes over. Manual control doesn’t seem to kick in until at least the first check in after it’s turned on.

@anoblet
Copy link

anoblet commented Jan 6, 2022

@broyuken Make sure that the lights defined in adaptive lighting match the lights in whatever automation you are using if any. If you set up adaptive lighting using a group of some sort (native/Zigbee) and try to set an individual light, AL won't respect that change.

@broyuken
Copy link
Author

broyuken commented Jan 7, 2022

It works fine after the first check in. But if I adjust the lights right away after AL changes them it doesn’t mark it as manually adjusted.

@RubenKelevra
Copy link
Collaborator

Hey @broyuken,

It works fine after the first check in. But if I adjust the lights right away after AL changes them it doesn’t mark it as manually adjusted.

While this might be a bug, version 2 is planned to get a completely new output module anyway, so this bug will likely disappear.

Additionally the manual/automatic controlling of lights/groups/rooms should be much more comfortable in v2 as well. So there might be a big improvement in "wife compatibility" ahead ;)

Keep this ticket open until you can verify that it's properly working in the upcoming version 2.

@broyuken
Copy link
Author

Awesome, thank you! I have a bunch of tickets open around manual control and random lights turning back on.

No pressure, and we’re not holding you to any hard dates but do you have a rough ETA on v2? Are you thinking days, weeks, months, next year, etc. really looking forward to any improvements because this is by far my most used integration.

@mikz
Copy link

mikz commented Jan 23, 2022

I've been debugging the same issue and it looks like if you adjust brightness after turning the light on it does not trigger manual mode on state change.

Brightness change is checked only when adapt light is called, so if you change brightness it first sets new adaptive light brightness and then sets manual mode and quits.

You could pre-emptively enable the set manual mode. Looking forward v2 too!

I know some Python and do a lot of other coding so I'm happy to test an early release/dev branch.

@bastiaanterhorst
Copy link

Resurrecting this as I am experiencing the same behaviour. A lot of work has happened on this component since this ticket was filed -- should this have been fixed in the mean time, or will an adjustment right after turning the lights on still be overridden by AL?

@broyuken
Copy link
Author

I think this is a planned fix for v2 whenever that is going to happen. I haven’t heard a rough ETA or anything yet

@basnijholt
Copy link
Owner

basnijholt commented Dec 16, 2022

Yes “v2” is really @RubenKelevra his project, but I have not seen a lot of code activity (yet 😉). I personally see a more gradual upgrade path as long as we continue with the current code. I don’t have a lot of time for a big rewrite unfortunately.

@cramertj
Copy link

Could you add a check in after the initial turn on transition for the light? If the light is where AL thinks it should be, great. If it's not, set it to manually controlled and stop adjusting it.

Another option would be to enable manual control (and stop adjusting) if a light is turned on at a different brightness than the last recorded brightness (when it was turned off). This would indicate that the light was turned on to an intentional brightness, and should not be adapted.

@broyuken
Copy link
Author

That wouldn’t work. If you turn a light off at noon when it should be at 100% and white, and then don’t turn it on again until 7pm when it should be 50% and warm it shouldn’t be set to manual control.

@th3w1zard1
Copy link
Collaborator

th3w1zard1 commented Mar 18, 2023

PR #486 fixes this issue.

@th3w1zard1 th3w1zard1 linked a pull request Apr 4, 2023 that will close this issue
@th3w1zard1
Copy link
Collaborator

th3w1zard1 commented Apr 4, 2023

@broyuken Hello! just wanted to let you know this should be fixed in 1.10.1

@broyuken
Copy link
Author

It does seem to be fixed, thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Inbox
Development

Successfully merging a pull request may close this issue.

9 participants