Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cascading TS repl inefficiency [JIRA: RIAK-3132] #767

Open
macintux opened this issue Dec 15, 2016 · 0 comments
Open

Cascading TS repl inefficiency [JIRA: RIAK-3132] #767

macintux opened this issue Dec 15, 2016 · 0 comments
Labels
JIRA: To Do

Comments

@macintux
Copy link
Contributor

Upon a casual reading, it appears that I'm unnecessarily re-wrapping objects in the w3 wire format for cascading replication.

riak_repl/src/riak_repl2_rtsink_conn.erl

Lines 305 to 308 in 23915a3

%% Timeseries data is an encoded tagged tuple
rtq_push(_Binary, {ts, PartIdx, Batch}, Meta) ->
riak_repl2_rtq:push(length(Batch),
riak_repl_util:to_wire(w3, {PartIdx, Batch}), Meta).

I suspect the first parameter, Binary, is equivalent to the result from riak_repl_util:to_wire(w3, {PartIdx, Batch}).
@Basho-JIRA Basho-JIRA changed the title Cascading TS repl inefficiency Cascading TS repl inefficiency [JIRA: RIAK-3132] Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JIRA: To Do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macintux @Basho-JIRA