Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sources other than github #21

Closed
binaryphile opened this issue Jul 11, 2016 · 4 comments
Closed

Allow sources other than github #21

binaryphile opened this issue Jul 11, 2016 · 4 comments

Comments

@binaryphile
Copy link

I use bitbucket in addition to github and it would be nice to be able to specify that as a source for a particular dependency in DEPS.

Perhaps an optional prepend of source to the DEP, which defaults to github if not specified, a la "bitbucket/my-user/my-package" or somesuch.

@juanibiapina
Copy link
Member

Great idea. Just like #20 , we should think about allowing this on the install command

@juanibiapina
Copy link
Member

juanibiapina commented Sep 17, 2016

@binaryphile and others: I want to get opinions on this syntax as an alternative to #22 :

$ basher install --protocol=ssh --site=github.com user/repo

Protocol will default to https and site to github.com. There should also be short options.

@juanibiapina juanibiapina changed the title allow other sources than github Allow sources other than github Sep 17, 2016
@juanibiapina
Copy link
Member

Another option would be:

$ basher install --protocol=ssh github.com/user/repo

This would allow you to overwrite the protocol when installing, but also allow the site to be specified on the dependencies section of the package.sh. The reasoning here is that you probably never want to specify the protocol when declaring dependencies, and not having the ":" on the package description allows it to be used on the DEPS= variable.

@juanibiapina
Copy link
Member

I just now realized your original suggestion already had the format a/b/c. So I'll go ahead and merge, closing this issue.

I'll open another issue for ssh access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants