Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basher list doesn't handle deeper directory structures #109

Open
nhomble opened this issue Jun 16, 2022 · 1 comment
Open

basher list doesn't handle deeper directory structures #109

nhomble opened this issue Jun 16, 2022 · 1 comment

Comments

@nhomble
Copy link
Contributor

nhomble commented Jun 16, 2022

I've been hosting some scripts in a gitlab organization which doesn't follow the nice username/project structure we have in github. It's more like org/group/function/repo.

When I do basher list, I only get part of the path which means basher upgrade trivially succeeds cause it doesn't find the git project to pull.

My current workaround is to manually pull in the basher cellar.

Looking at the implementation, the assumption looks to be in the package_path loop in basher-list

for package_path in "${BASHER_PACKAGES_PATH}"/*/*
.
.
.

--
@juanibiapina maybe we can come up with a better list of git repos with find?

@juanibiapina
Copy link
Member

Yeah, or a better glob pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants