Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when indexing StepRange with begin and end #83

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

bbejanov
Copy link
Member

@bbejanov bbejanov commented Dec 9, 2024

julia> (2020Q1:2:2022Q4)[end]
ERROR: promotion of types Duration{Quarterly{3}} and Duration{Quarterly{3}} failed to change any arguments
Stacktrace:
 [1] error(::String, ::String, ::String)
   @ Base ./error.jl:44
 [2] sametype_error(input::Tuple{Duration{Quarterly{3}}, Duration{Quarterly{3}}})
   @ Base ./promotion.jl:417
 [3] not_sametype(x::Tuple{Duration{…}, Duration{…}}, y::Tuple{Duration{…}, Duration{…}})
   @ Base ./promotion.jl:411
 [4] *(a::Duration{Quarterly{3}}, b::Duration{Quarterly{3}})
   @ Base ./int.jl:1067
 [5] getindex(v::StepRange{MIT{Quarterly{3}}, Duration{Quarterly{3}}}, i::Duration{Quarterly{3}})
   @ Base ./range.jl:944
 [6] top-level scope
   @ REPL[3]:1
Some type information was truncated. Use `show(err)` to see complete types.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (726ec66) to head (eb420e0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   93.60%   93.50%   -0.11%     
==========================================
  Files          24       24              
  Lines        4849     4851       +2     
==========================================
- Hits         4539     4536       -3     
- Misses        310      315       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbejanov bbejanov merged commit 3a46f6f into master Dec 9, 2024
9 checks passed
@bbejanov bbejanov deleted the steprangebug branch December 9, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants