Fix recipe for histograms plots #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have encountered no errors with this on the plots we use. |
jasonjensen
approved these changes
Dec 12, 2023
Nic2020
approved these changes
Dec 12, 2023
e.g. `float(2021Q1:2022Q4)` returns `2021.0:0.25:2022.75`
bbejanov
force-pushed
the
hist_recipe
branch
from
20bc8ee to
b6f3f79
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 92.52% 92.90% +0.37%
==========================================
Files 20 20
Lines 2904 2918 +14
==========================================
+ Hits 2687 2711 +24
+ Misses 217 207 -10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the tseries plot recipe for different seriestypes.
The current implementation always plots TSeries with
seriestype=:path, even if the TSeries were passed tohistogram()orscatter(), for example.In this PR we preserve the original
seriestype. We also handle correctly the case ofseriestype=:histogram, which uses only the values, not the range.