Fix bugs in shift
and hcat
for MVTSeries
#69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in
shift
is that it updates only the first date of the MVTSeries, but not the firstdate of the individual columns TSeries views. As a result,rangeof(lag(A))
is shifted, butrangeof(lag(A).a)
is not.The bug is
hcat
is that the range of the result is the range of the first argument and does not take into account the rest of the arguments. In the updated version the range of the result is calculated as therangeof_span
of all arguments that are tohcat
'd.