Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in shift and hcat for MVTSeries #69

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

bbejanov
Copy link
Member

Bug in shift is that it updates only the first date of the MVTSeries, but not the firstdate of the individual columns TSeries views. As a result, rangeof(lag(A)) is shifted, but rangeof(lag(A).a) is not.

The bug is hcat is that the range of the result is the range of the first argument and does not take into account the rest of the arguments. In the updated version the range of the result is calculated as the rangeof_span of all arguments that are to hcat'd.

@bbejanov bbejanov changed the title Fix bugs in shift and hcat for MVTSeries Fix bugs in shift and hcat for MVTSeries Apr 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.73%. Comparing base (e072557) to head (ae61563).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           65-rename-columns      #69      +/-   ##
=====================================================
+ Coverage              93.70%   93.73%   +0.02%     
=====================================================
  Files                     24       24              
  Lines                   4800     4807       +7     
=====================================================
+ Hits                    4498     4506       +8     
+ Misses                   302      301       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbejanov bbejanov merged commit ef752ba into 65-rename-columns Apr 16, 2024
9 checks passed
@bbejanov bbejanov deleted the fix-shift branch April 16, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants