Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve string diff visualization #160

Open
MartinDelille opened this issue Mar 28, 2020 · 2 comments
Open

Improve string diff visualization #160

MartinDelille opened this issue Mar 28, 2020 · 2 comments
Labels
feature Feature request inaction No action required by me, or I am not going to fix the issue.

Comments

@MartinDelille
Copy link
Contributor

Visualising difference on big string is tricky.

I found this library: https://github.com/cubicdaiya/dtl

Do you think we could use it to improve string diff visualisation?

@sbeyer sbeyer added feature Feature request inaction No action required by me, or I am not going to fix the issue. labels Mar 28, 2020
@sbeyer
Copy link
Member

sbeyer commented Mar 28, 2020

I think any attempts to visualize difference in the actual and expected strings in bandit (or snowhouse) would be feature creep.

@sbeyer
Copy link
Member

sbeyer commented Apr 16, 2021

I am currently using GTest at work and I noticed that GTest provides diff output. I never found it really useful but I can imagine that it may make sense for big strings (like file content).

I could imagine for snowhouse that it can be possible to register callbacks to assertions, and these callbacks are called when the assertion fails. This would allow the user to register a string diff routine (which could be mentioned as concrete example in the documentation, maybe using dti).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request inaction No action required by me, or I am not going to fix the issue.
Projects
None yet
Development

No branches or pull requests

2 participants