Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation #5

Closed

Conversation

Sachindu-Nethmin
Copy link
Contributor

Add Documentation

Purpose

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

Add Documentation
Copy link
Contributor

@aashikam aashikam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sachindu-Nethmin Hi, I added a small comment, rest of it looks fine.

@Sachindu-Nethmin
Copy link
Contributor Author

@aashikam please review

@aashikam
Copy link
Contributor

aashikam commented Dec 6, 2024

@Sachindu-Nethmin Hey

Hiding sensitive information such as access tokens and client IDs in Git pull requests is critical to prevent unauthorized access and potential security breaches. Exposing such credentials can allow attackers to exploit your application, access restricted resources, or compromise user data, leading to serious damage.

7de1d1a This commit itself is a big security vulnerability. 😃

Even though you have removed it, by viewing the commit anyone still has access to the information.

To remove this from git history you will have to do a hard reset. Here are the steps:

  1. Check the commit history: Run git log to view your commit history and identify the commit hash (e.g., abc123) you want to reset to.
  2. Perform the hard reset: Execute git reset --hard <commit-hash> to move the branch pointer to the specified commit and discard any changes in the working directory or staging area.
  3. Verify the reset: Run git log again to confirm the branch now points to the desired commit.
  4. Push the changes: Use git push --force to overwrite the remote branch

After that please add an example. Here is a sample PR: ballerina-platform/module-ballerinax-dropbox#6

@aashikam
Copy link
Contributor

aashikam commented Dec 6, 2024

@Sachindu-Nethmin Hey

Documentation includes all these files:
Screenshot 2024-12-06 at 09 58 44

I see that you have only updated the README.md. It's pretty much the same content.
Here is a sample PR: ballerina-platform/module-ballerinax-dropbox#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants