Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nillable and optional fields to be read as record field #1313

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

daneshk
Copy link
Member

@daneshk daneshk commented Dec 3, 2024

Purpose

Fixes: ballerina-platform/ballerina-library#7433

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@daneshk daneshk changed the title Allow nil values to be read as record field Allow nillable and optional fields to be read as record field Dec 4, 2024
ayeshLK
ayeshLK previously approved these changes Dec 4, 2024
Copy link
Member

@ayeshLK ayeshLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ballerina/tests/negative.bal Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 4, 2024

@daneshk daneshk merged commit cb542c5 into ballerina-platform:master Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CSV file read as a record failed when a nillable field was empty
3 participants