Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Svelte Dependency to Version 4.0.0 or Higher #58

Closed
ptavarez opened this issue Jul 31, 2024 · 5 comments · Fixed by #59
Closed

Update Svelte Dependency to Version 4.0.0 or Higher #58

ptavarez opened this issue Jul 31, 2024 · 5 comments · Fixed by #59

Comments

@ptavarez
Copy link

Description

We are trying to upgrade from Storybook 6 to Storybook 8 in sf-ui-web and encountered an issue with JamBox's Svelte dependency. Storybook 8 requires Svelte version 4, but JamBox is currently using Svelte version 3.

Error

Screenshot 2024-07-31 at 2 54 06 PM

Request

Please update the Svelte dependency in JamBox to version 4.0.0 or higher to ensure compatibility with Storybook 8.

Thank you!

@ptavarez
Copy link
Author

I could spin up a PR for this! Just let me know what would be most helpful 😄

@ballercat
Copy link
Owner

Okay no problem. I can probably get to that today.

@ptavarez
Copy link
Author

ptavarez commented Aug 1, 2024

Sweet, thank you!

@ballercat
Copy link
Owner

#59

This will do it... Please be aware that there is a nasty bug in Cypress 13.x (which I had to upgrade to) which causes it to no longer find a devServer for component tests. I had to disable cypress checks in CI in order to get it actually to build. I suspect it's something to do with it no longer accurately handling proxied requests.

cypress-io/cypress#27990

@ballercat
Copy link
Owner

Version 0.4.2 was published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants