Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate symbols for architecture #33

Open
Procaseycash opened this issue Dec 9, 2019 · 8 comments
Open

Duplicate symbols for architecture #33

Procaseycash opened this issue Dec 9, 2019 · 8 comments

Comments

@Procaseycash
Copy link

Procaseycash commented Dec 9, 2019

I have ran ./renameLogger.sh to resolve this issue but did not get to work as React-Native version 0.60+ do not contains the third-party folder. see details below;

"dependencies": {
    "react": "16.9.0",
    "react-native": "0.61.5",
    "react-native-nearby-api": "0.0.5"
  },

Currently running the example provided here. this works for IOS & Android on 0.56 of react-native.

Thanks.

@zaptrem
Copy link

zaptrem commented Feb 24, 2020

Same issue here. Did you figure it out?

@zaptrem
Copy link

zaptrem commented Feb 24, 2020

Might have solved this issue by pasting this at bottom of podfile:

puts "Renaming logging functions"

  root = File.dirname(installer.pods_project.path)
  Dir.chdir(root);
  Dir.glob("**/*.{h,cc,cpp,in}") {|filename|
    filepath = root + "/" + filename
    text = File.read(filepath)
    addText = text.gsub!(/(?<!React)AddLogSink/, "ReactAddLogSink")
    if addText
      File.chmod(0644, filepath)
      f = File.open(filepath, "w")
      f.write(addText)
      f.close
    end

    text2 = addText ? addText : text
    removeText = text2.gsub!(/(?<!React)RemoveLogSink/, "ReactRemoveLogSink")
    if removeText
      File.chmod(0644, filepath)
      f = File.open(filepath, "w")
      f.write(removeText)
      f.close
    end
  }

@Procaseycash
Copy link
Author

Please check the fix from https://github.com/adrianso/react-native-nearby-api. Also works with latest version of react native too

@zaptrem
Copy link

zaptrem commented Feb 24, 2020

I tried that but got an error “Multiple commands create (some path)/Assets.car.” When I tried the legacy build system I got some error about multiple arm symbols conflicting.

@mrousavy
Copy link

@zaptrem I'm getting the same error, did you manage to fix it?

@zaptrem
Copy link

zaptrem commented May 25, 2020 via email

@mrousavy
Copy link

mrousavy commented May 25, 2020

@zaptrem Awesome it worked! Seems really weird to me to manually remove Assets, hopefully this doesn't have any side effects.

@mrousavy
Copy link

mrousavy commented Jun 3, 2020

I've created a new library for the Nearby API here: https://github.com/mrousavy/react-native-google-nearby-messages because apparently this one is dead. It uses the latest version, supports autolinking and was made with Swift.
The Assets.car issue still exists, it's Google's fault on the NearbyMessages pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants