Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Github Copilot Plugin: Change in average acceptance rate calculations #2060

Open
2 tasks done
ericy-orbis opened this issue Nov 22, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@ericy-orbis
Copy link

Plugin Name

Github Copilot

📜 Description

The new changes introduced in seem to have altered the behaviour of average acceptance rate calculations:

The new way has a much lower acceptance rate and its because of this change to the calculations:

total_lines_accepted/total_lines_suggested
instead of
total_acceptances_count/total_suggestions_count

Is this the correct behaviour now or a bug? I hope that the PRs title can reflect what was actually changed as end users it looks like the chart data suddenly changed on us without prior notice.

Previously in Oct this PR was introduced to use total_acceptances_count/total_suggestions_count to be inline with other plugins
[https://github.com/https://github.com//pull/1503]

But now its back to using total_lines_accepted/total_lines_suggested

Please let us know!

Thanks,
Eric

👍 Expected behavior

total_acceptances_count/total_suggestions_count

👎 Actual Behavior with Screenshots

total_lines_accepted/total_lines_suggested

copilot-new2
copilot-old2
query

👟 Reproduction steps

See screenshots above for the same date.

📃 Provide the context for the Bug.

The PR seems to have reverted the calcaculations for average acceptance rate back to lines of code. It would be nice if the PR mentioned if that is the intended change, so that us end users dont need to guess why the metrics suddenly changed on us.

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@ericy-orbis ericy-orbis added the bug Something isn't working label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant