Follow-up to #6987: Regression in contrib projects using text_field_is_empty() with only 2 params

[indigoxela]

Description of the bug

It turned out, that several modules rely on other module's hook_field_is_empty(). For example paragraphs and field_collection, which need to check fields attached to those entities.

The change happened in #6987 when invoking hook_field_is_empty(). There's also #7058 to deal with _field_filter_items().

Steps To Reproduce

... update to 1.33

Use a module which invokes hook_field_is_empty(). https://github.com/search?q=org%3Abackdrop-contrib+%27field_is_empty%27&type=code. For example, an older release of Paragraphs: module_invoke($field['module'], 'field_is_empty', $field_item, $field).

Actual behavior

Fatal errors under circumstances...

For example, the older release of Paragraphs (or Field Collection, etc) would check text_field_is_empty() which results in:

ArgumentCountError: Too few arguments to function text_field_is_empty()

Expected behavior

...

Additional information

Add any other information that could help, such as:

• Backdrop CMS version: introduced with 1.33
• Web server and its version:
• PHP version:
• Database sever (MySQL or MariaDB?) and its version:

[laryn]

Ref: https://backdrop.zulipchat.com/#narrow/channel/218635-Backdrop/topic/Too.20few.20args.20in.20_field_filter_items.20and.20text_field_is_empty/with/568450393

[herbdool]

I created #7058 to see if we want to deal with _field_filter_items() as well.

[herbdool]

I've create a PR that makes sure that $instance doesn't need to exist in text_field_is_empty

[indigoxela]

@herbdool many thanks for the PR 🙏

This is how I tested:

• on latest dev of Backdrop
• installed field_collection with dependencies
• created a collection with a short text and an image field, collection attached on node type
• tried to create a node of that type with a value for text field on that collection

And, of course, there was a fatal error. Impossible to save that node.
(Leaving both fields empty or only adding an image did not cause the fatal, only values in the text field.)

• Applied the PR patch.
• tried to save such a node with text value, and that works like a charm

Note that the actual "empty" check in Field Collection doesn't work properly, and an empty collection shows up, although configured to hide them (edit: has nothing to do with core change). But there's no fatal error, which was what we try to achieve here. Works for me! 👍