Disabled comments are still listed in Manage Comments view

[quicksketch]

Description of the bug

When comments are disabled for a content type, on the page "Manage comments" (admin/content/comment) the comments related to that type are still linked in the list, but the link goes to non-existing comments, e.g. example.com/comment/3#comment-3.

This is a follow-up to #3016, where this feature was introduced.

Steps To Reproduce

To reproduce the behavior:

1. Use the 1.x / 1.33.0-preview version
2. Ensure comments are enabled on the post content type and a comment on a post node.
3. Disable comments on the post type.
4. Visit admin/content/comment
5. See/click on the comment posted in step 2.

The comment is not visible on the linked page, because comments were disabled on the node type. The comment should not be shown in the admin/content/comment listing at all when comments are disabled on the type.

Additional information

• Backdrop CMS version: 1.33.x

[quicksketch]

PR filed at backdrop/backdrop#5199 that should fix this issue by using hook_query_alter().

Because comment listings are always tied to nodes, which always have the node_access query tag, we can use that same tag to filter out node types that have comments disabled.

This code is very similar to _node_search_query_alter(), where nodes are excluded from listing if the "hidden_path" setting is enabled. Only instead of checking "hidden_path" we check "comment_enabled". If selecting from the comment table, node types that have comments disabled are excluded from the resulting query.

PR still needs test coverage.

[quicksketch]

backdrop/backdrop#5199 now has test coverage and fixed a Views test that was affected by Page nodes not having comments enabled by default now.

[quicksketch]

This isn't urgent for the 1.33.0 release so I'm moving it to the first bug fix release.

[olafgrabienski]

Thanks for filing the issue and providing the PR! I've tested the fix in the PR sandbox:

After posting a comment and disabling comments for the content type, the comment wasn't anymore in the admin/content/comment listing. After enabling comments again, the comment was in the listing. So, works like a charm!