Improve Github Actions Workflow and GoLint #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Improve go linting and decouple it from pre-commits 2. Create the Notion of a pipeline in github actions, and not just standalone workflows 3. Use CI built binaries in Test Containers Suite Linear: https://linear.app/expanso/issue/ENG-292/bring-back-lint and https://linear.app/expanso/issue/ENG-286/unify-our-cicd-location Github: #4639 and #4650
frrist
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
This PR improves the Go-Linting structure in our CI, as well as move the Github Actions workflows into the "Pipeline" mentality, rather than individual Workflows.
Changes:
Github actions pipeline will look like this: