From 0b0a84e3dd93e05faf5220239facd6d583af03fe Mon Sep 17 00:00:00 2001
From: frrist <forrest@expanso.io>
Date: Tue, 10 Sep 2024 11:41:36 -0700
Subject: [PATCH] fix: remove env vars from config list output

- provide complete help text for the command.
- close #4395
---
 cmd/cli/config/list.go | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/cmd/cli/config/list.go b/cmd/cli/config/list.go
index 63af9306af..fe0b380b1b 100644
--- a/cmd/cli/config/list.go
+++ b/cmd/cli/config/list.go
@@ -10,7 +10,6 @@ import (
 	"github.com/bacalhau-project/bacalhau/cmd/util/flags/cliflags"
 	"github.com/bacalhau-project/bacalhau/cmd/util/hook"
 	"github.com/bacalhau-project/bacalhau/cmd/util/output"
-	"github.com/bacalhau-project/bacalhau/pkg/config"
 	"github.com/bacalhau-project/bacalhau/pkg/config/types"
 )
 
@@ -23,8 +22,13 @@ func newListCmd() *cobra.Command {
 		Wide:       false,
 	}
 	listCmd := &cobra.Command{
-		Use:      "list",
-		Short:    "List all config keys.",
+		Use:   "list",
+		Short: "List all config keys and their descriptions",
+		Long: `The config list command displays all available configuration keys along with their detailed descriptions.
+This comprehensive list helps you understand the settings you can adjust to customize the bacalhau's behavior. 
+Each key shown can be used with: 
+- bacalhau config set <key> <value> to directly set the value
+- bacalhau --config=<key>=<value> to temporarily modify the setting for a single command execution`,
 		Args:     cobra.MinimumNArgs(0),
 		PreRunE:  hook.ClientPreRunHooks,
 		PostRunE: hook.ClientPostRunHooks,
@@ -38,7 +42,6 @@ func newListCmd() *cobra.Command {
 
 type configListEntry struct {
 	Key         string
-	EnvVar      string
 	Description string
 }
 
@@ -51,7 +54,6 @@ func list(cmd *cobra.Command, o output.OutputOptions) error {
 	for key, description := range types.ConfigDescriptions {
 		cfgList = append(cfgList, configListEntry{
 			Key:         key,
-			EnvVar:      config.KeyAsEnvVar(key),
 			Description: description,
 		})
 	}
@@ -70,12 +72,6 @@ var listColumns = []output.TableColumn[configListEntry]{
 			return s.Key
 		},
 	},
-	{
-		ColumnConfig: table.ColumnConfig{Name: "Environment Variable", WidthMax: 80, WidthMaxEnforcer: text.WrapHard},
-		Value: func(v configListEntry) string {
-			return fmt.Sprintf("%v", v.EnvVar)
-		},
-	},
 	{
 		ColumnConfig: table.ColumnConfig{Name: "Description", WidthMax: 80, WidthMaxEnforcer: text.WrapText},
 		Value: func(v configListEntry) string {