Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please improve the error message when missing volume #4787

Open
aronchick opened this issue Dec 18, 2024 · 1 comment
Open

Please improve the error message when missing volume #4787

aronchick opened this issue Dec 18, 2024 · 1 comment
Labels
request/new Request: Indicates a new request that has been submitted and awaits initial triage type/bug Type: Something is not working as expected

Comments

@aronchick
Copy link
Collaborator

aronchick commented Dec 18, 2024

Improve error messages here:

Execution e-f45b4658 History
 TIME                 TOPIC          EVENT
 2024-12-18 18:41:36  Scheduling     Requested execution on 0b0a2a4c
 2024-12-18 18:41:37  Exec Scanning  Error: calculating resource usage of job: error getting job disk space requirements: volume does not exist

The job:

❯ more start-logging-container.yaml
Count: 1
Tasks:
  - Engine:
      Params: [...]
      Type: docker
    Name: sample-job
    InputSources:
      - Source:
          Type: "localDirectory"
          Params:
            SourcePath: "/var/log/logs_to_process"
            ReadWrite: true
        Target: "/var/log/logs_to_process"

answer: the directory on the server was not there. we should have a cleaner error please.

In this case - the volume wasn't on the host (not in the container). I think we should be able to say that? (Could this be an attack vector? Probably - need to think it through).

@aronchick aronchick added type/bug Type: Something is not working as expected request/new Request: Indicates a new request that has been submitted and awaits initial triage labels Dec 18, 2024
Copy link

linear bot commented Dec 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request/new Request: Indicates a new request that has been submitted and awaits initial triage type/bug Type: Something is not working as expected
Projects
None yet
Development

No branches or pull requests

1 participant