Preserve LastComputeSeqNum if 0

[wdbaruni]

Only update LastComputeSeqNum if greater than 0, as zero can indicate
either no messages processed yet or a connection that has just been
established. This preserves the existing sequence number in those cases.

Summary by CodeRabbit

• New Features

  • Enhanced node management with improved health monitoring and state persistence.
  • Added conditional logic to prevent overwriting sequence numbers with zero.
  • Improved handling of disconnected nodes to retain existing connection states.

• Bug Fixes

  • Adjusted control flow and error handling for better robustness in node state updates.

• Documentation

  • Added logging statements for improved visibility into state transitions and error conditions.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the node management system in the pkg/orchestrator/nodes/manager.go file. The changes focus on improving node health tracking, state persistence, and connection management. Key updates include conditional sequence number updates, refined state enrichment for disconnected nodes, and enhanced self-registration logic. The modifications aim to provide more robust handling of node states, ensuring accurate tracking of connection timestamps and sequence numbers.

Changes

File	Change Summary
pkg/orchestrator/nodes/manager.go	- Updated updateSequenceNumbers to conditionally set LastComputeSeqNum - Modified enrichState to preserve disconnected node connection state - Refined selfRegister method to correctly update node connection state

Possibly related PRs

• improve orchestrator node self-registeration #4762: Modifies the selfRegister method, directly related to connection state updates during node registration
• better exchange of starting seqNum during handshakes #4766: Updates the Handshake method, aligning with improvements to node management functionality

Poem

🐰 In the realm of nodes, a rabbit's delight,
Sequences dance, connections take flight
State persists with careful grace,
Disconnected nodes find their space
Code evolves, robust and bright! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9135124 and 00c115d.

📒 Files selected for processing (1)

• pkg/orchestrator/nodes/manager.go (1 hunks)

🔇 Additional comments (1)

pkg/orchestrator/nodes/manager.go (1)

857-859: Preserve LastComputeSeqNum when computeSeq is zero

The conditional check correctly ensures that LastComputeSeqNum is only updated when computeSeq > 0. This prevents unintended overwrites of the existing sequence number when computeSeq is zero, which could indicate that no messages have been processed yet or a new connection has just been established. This change aligns with the PR objectives and maintains accurate sequence number tracking.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.