Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace / with - in job progress tracker #4529

Merged
merged 3 commits into from
Sep 26, 2024
Merged

replace / with - in job progress tracker #4529

merged 3 commits into from
Sep 26, 2024

Conversation

wdbaruni
Copy link
Member

For job level events, we now print ---------- instead / under executionDI

 TIME          EXEC. ID    TOPIC            EVENT
 09:12:32.194  /           Submission       Job submitted
 09:12:32.216  e-a201aa76  Scheduling       Requested execution on n-f057ce5e
 09:12:32.257  e-a201aa76  Execution        Running
 09:12:32.475  e-a201aa76  Execution        Completed successfully
 TIME          EXEC. ID    TOPIC            EVENT
 14:08:03.138  ----------  Submission       Job submitted
 14:08:03.149  e-d3860563  Scheduling       Requested execution on n-c5d27044
 14:08:03.202  e-d3860563  Execution        Running
 14:08:06.614  e-d3860563  Execution        Completed successfully

Closes #4505

@wdbaruni wdbaruni requested a review from aronchick September 25, 2024 12:10
@wdbaruni
Copy link
Member Author

@aronchick to clarify, we have some events for job level state update and others for execution level. Mostly execution updates. I've replaced / with ---------- as suggested in #4505 , but let me know if you have other suggestions now the content is clearer

@wdbaruni wdbaruni marked this pull request as ready for review September 25, 2024 12:11
@wdbaruni
Copy link
Member Author

To be honest it doesn't look easier on the eye when querying all history events for a job, such as :

Walid-MacBook-5: ~
→       bacalhau job history j-c7bf0dac-5981-4147-9d16-301b5e132613 --no-style
 TIME                 LEVEL           EXEC. ID    TOPIC         EVENT
 Sep 25 14:08:03.138  JobLevel        ----------  Submission    Job submitted
 Sep 25 14:08:03.149  ExecutionLevel  e-d3860563  Scheduling    Requested execution on n-c5d27044
 Sep 25 14:08:03.202  JobLevel        ----------  State Update  Running
 Sep 25 14:08:03.202  ExecutionLevel  e-d3860563  Execution     Running
 Sep 25 14:08:06.614  ExecutionLevel  e-d3860563  Execution     Completed successfully
 Sep 25 14:08:06.627  JobLevel        ----------  State Update  Completed

@aronchick
Copy link
Collaborator

yeah - maybe just blank? The problem is '' looked like something broken

Copy link
Collaborator

@aronchick aronchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just blank?

Comment on lines 35 to 38
ColumnConfig: table.ColumnConfig{Name: "Exec. ID", WidthMax: 10, WidthMaxEnforcer: text.WrapText},
Value: func(j *models.JobHistory) string {
if j.ExecutionID == "" {
return "/"
return strings.Repeat("-", 10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to extract 10 to a constant given it must match the column max width

@wdbaruni wdbaruni merged commit 114bce6 into main Sep 26, 2024
3 of 4 checks passed
@wdbaruni wdbaruni deleted the progress-job-id branch September 26, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's have a centered "--" for No Execution ID (yet)
3 participants