-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace / with - in job progress tracker #4529
Conversation
@aronchick to clarify, we have some events for job level state update and others for execution level. Mostly execution updates. I've replaced |
To be honest it doesn't look easier on the eye when querying all history events for a job, such as :
|
yeah - maybe just blank? The problem is '' looked like something broken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just blank?
cmd/util/cols/history.go
Outdated
ColumnConfig: table.ColumnConfig{Name: "Exec. ID", WidthMax: 10, WidthMaxEnforcer: text.WrapText}, | ||
Value: func(j *models.JobHistory) string { | ||
if j.ExecutionID == "" { | ||
return "/" | ||
return strings.Repeat("-", 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to extract 10
to a constant given it must match the column max width
For job level events, we now print
----------
instead/
under executionDICloses #4505