Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--labels flag doesn't work #4396

Closed
wdbaruni opened this issue Sep 10, 2024 · 2 comments
Closed

--labels flag doesn't work #4396

wdbaruni opened this issue Sep 10, 2024 · 2 comments
Assignees
Labels
th/game-day Issues reported during game day testing

Comments

@wdbaruni
Copy link
Member

While --labels flag is deprecated in favour of -c compute.labels=name=john, we should still make it functional to maintain backward compatibility and avoid breaking existing networks and examples that rely on --labels flag

@wdbaruni wdbaruni added the th/game-day Issues reported during game day testing label Sep 10, 2024
@frrist
Copy link
Member

frrist commented Sep 10, 2024

In what way is the flag not working?

From main:
bacalhau serve --node-type=requester,compute --labels=foo=bar,buz=bat

bacalhau node list
 ID          TYPE     APPROVAL  STATUS     LABELS                                              CPU     MEMORY      DISK         GPU  
 n-3209262e  Compute  APPROVED  CONNECTED  Architecture=amd64 GPU-0-Memory=8192-MiB            22.4 /  32.9 GB /   1.1 TB /     1 /  
                                           GPU-0=NVIDIA-GeForce-RTX-2080-SUPER                 22.4    32.9 GB     1.1 TB       1    
                                           Operating-System=linux buz=bat foo=bar                                                    

@wdbaruni
Copy link
Member Author

I tried this:

bacalhau serve --compute --orchestrator=false -c compute.labels="name=compute,region=iad" --labels env=prod

Though I see that -c compute.labels is just taking precedence, which makes sense

@github-project-automation github-project-automation bot moved this from Inbox to Done in Engineering Planning Sep 10, 2024
@frrist frrist self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
th/game-day Issues reported during game day testing
Projects
Status: Done
Development

No branches or pull requests

2 participants