Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Repo initialization #3845

Open
wdbaruni opened this issue Feb 12, 2024 · 1 comment
Open

Revisit Repo initialization #3845

wdbaruni opened this issue Feb 12, 2024 · 1 comment
Assignees
Labels
th/config Theme: Related to configuration files and settings across the project type/tech-debt Type: Issues meant to address technical debt
Milestone

Comments

@wdbaruni
Copy link
Member

The repo is initialized in the RootCmd before any flags are registered. This means only default configurations are used when initializing the repo and any env variables or flags will be ignored. For example, if I run bacalhau serve --compute-execution-store-path my-awesome-path for the very first time, then bacalhau will still initialize the repo with default value, create ~/.bacalhau/compute-store directory, and create config.yaml with ~/.bacalhau/compute-store instead of my provided one. It is difficult to do things differently with our current setup as we initialize the repo in any command, but these flags are only available for serve command

Reference: #3429

@wdbaruni wdbaruni added the type/tech-debt Type: Issues meant to address technical debt label Feb 12, 2024
@wdbaruni wdbaruni transferred this issue from another repository Apr 21, 2024
@wdbaruni wdbaruni transferred this issue from another repository Apr 21, 2024
@wdbaruni wdbaruni added the th/config Theme: Related to configuration files and settings across the project label Apr 22, 2024
@wdbaruni
Copy link
Member Author

Will be addressed as part of #4014

@wdbaruni wdbaruni added this to the v1.5.0 milestone Jun 26, 2024
@wdbaruni wdbaruni moved this from Inbox to Next in Engineering Planning Jun 26, 2024
@wdbaruni wdbaruni assigned wdbaruni and unassigned frrist Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
th/config Theme: Related to configuration files and settings across the project type/tech-debt Type: Issues meant to address technical debt
Projects
Status: Next
Development

No branches or pull requests

2 participants