Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalise the flags to disable features #3662

Closed
rossjones opened this issue Mar 20, 2024 · 2 comments
Closed

Normalise the flags to disable features #3662

rossjones opened this issue Mar 20, 2024 · 2 comments
Assignees
@frrist
Labels
comp/cli Anything that affects the command-line interface good first issue Good for newcomers th/config Theme: Related to configuration files and settings across the project th/user-experience Theme: Issues aimed at improving the end-user experience

Comments

@rossjones
Copy link
Contributor

We currently have a few flags we can pass to serve to turn off individual features.
Unfortunately, one of the flags is ever so slightly different and it might be best to make it more consistent.

--disable-engine       Engine types to disable
--disable-storage      Storage types to disable
--disabled-publisher   Publisher types to disable
@rossjones rossjones added the th/user-experience Theme: Issues aimed at improving the end-user experience label Mar 20, 2024
@wdbaruni wdbaruni added type/tech-debt Type: Issues meant to address technical debt comp/cli Anything that affects the command-line interface th/config Theme: Related to configuration files and settings across the project and removed type/tech-debt Type: Issues meant to address technical debt labels Apr 16, 2024
@wdbaruni wdbaruni added the good first issue Good for newcomers label May 4, 2024
@frrist
Copy link
Contributor

frrist commented Jun 26, 2024

@wdbaruni when I completed this change do you want to deprecate (hide, but don't remove) the --disabled-publisher and replace it with --disable-publisher? Or just rename it?

@wdbaruni
Copy link
Member

as part of https://www.notion.so/expanso/Rethinking-Configuration-435fbe87419148b4bbc5119d413786eb, we will remove the CLI flags and replace them with a Publishers.Disabled configuration.

I just assigned this to you so that you can mark it as closed when #4014 is delivered, but maybe better to close this issue now to avoid confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frrist frrist

Labels
comp/cli Anything that affects the command-line interface good first issue Good for newcomers th/config Theme: Related to configuration files and settings across the project th/user-experience Theme: Issues aimed at improving the end-user experience
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rossjones @frrist @wdbaruni