Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobSelectionPolicy is un-used for the requester node #2929

Closed
frrist opened this issue Oct 17, 2023 · 4 comments
Closed

JobSelectionPolicy is un-used for the requester node #2929

frrist opened this issue Oct 17, 2023 · 4 comments
Labels
type/bug Type: Something is not working as expected

Comments

@frrist
Copy link
Member

frrist commented Oct 17, 2023

Both the Compute and Requester Node support a JobSelectionPolicy. At present, the Requester node accepts a policy in its configuration but fails to apply/use it anywhere. The task here is to re-enable support for the JobSelectionPolicy in the Requester Node. This issue was discovered while investigating #2898 will will follow the fix there.

@frrist frrist added the type/bug Type: Something is not working as expected label Oct 17, 2023
@frrist
Copy link
Member Author

frrist commented Oct 17, 2023

The removal of the JobSelectionPolicy from the requester was made while upgrading to the evaluation broker via: https://github.com/bacalhau-project/bacalhau/pull/2681/files#diff-db482b8c1643fdf50b3648bd443784dfa31ceac24f6c6994f421c42f73d419eaL132-L137

I believe we'll need to incorporate the previous logic of the JobSelectionPolicy into the Evaluation Brokers NodeRanker to preserve existing behavior.

@wdbaruni @simonwo does that sound right to you? Do we want to keep the JobSelectionPolicy as a strategy used by the Requester node while ranking nodes?

@aronchick
Copy link
Collaborator

Stale?

@simonwo
Copy link
Contributor

simonwo commented Jan 5, 2024

I think it's still an issue and we should still look to restore this feature. Stopping jobs that don't meet policy should be done as early as we can, i.e. in the Requester.

@wdbaruni
Copy link
Member

we can close this as we are moving more towards config files instead of cli flags to configure nodes #4014

@github-project-automation github-project-automation bot moved this from Inbox to Done in Engineering Planning Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: Something is not working as expected
Projects
Status: Done
Development

No branches or pull requests

4 participants