-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JobSelectionPolicy is un-used for the requester node #2929
Comments
The removal of the JobSelectionPolicy from the requester was made while upgrading to the evaluation broker via: https://github.com/bacalhau-project/bacalhau/pull/2681/files#diff-db482b8c1643fdf50b3648bd443784dfa31ceac24f6c6994f421c42f73d419eaL132-L137 I believe we'll need to incorporate the previous logic of the JobSelectionPolicy into the Evaluation Brokers @wdbaruni @simonwo does that sound right to you? Do we want to keep the JobSelectionPolicy as a strategy used by the Requester node while ranking nodes? |
Stale? |
I think it's still an issue and we should still look to restore this feature. Stopping jobs that don't meet policy should be done as early as we can, i.e. in the Requester. |
we can close this as we are moving more towards config files instead of cli flags to configure nodes #4014 |
Both the Compute and Requester Node support a JobSelectionPolicy. At present, the Requester node accepts a policy in its configuration but fails to apply/use it anywhere. The task here is to re-enable support for the JobSelectionPolicy in the Requester Node. This issue was discovered while investigating #2898 will will follow the fix there.
The text was updated successfully, but these errors were encountered: