Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support percentage values in CPU/memory limit flags #2367

Closed
simonwo opened this issue Apr 15, 2023 · 1 comment
Closed

Support percentage values in CPU/memory limit flags #2367

simonwo opened this issue Apr 15, 2023 · 1 comment
Assignees
Labels
good first issue Good for newcomers th/config Theme: Related to configuration files and settings across the project type/enhancement Type: New features or enhancements to existing features
Milestone

Comments

@simonwo
Copy link
Contributor

simonwo commented Apr 15, 2023

We accept command line flags to limit the resources used per job and used by all jobs. This is useful for users who want to run Bacalhau nodes on shared machines which are also providing other services.

However, these flags take absolute values only (eg 1 CPU core, 2Gb RAM). For users (like Starion) who are deploying over a wide breadth of different machines, this is problematic because on some clients 2Gb RAM might be the full amount and on others it might be a too small amount.

What would be better was if we could supply percentage values and have Bacalhau work out the correct absolute values (it already knows how to read the available cores and RAM). Then Station could just say “use no more than 50% of RAM” and be confident that this scales to all machine types.

Make the existing CLI flags able to accept values that end in a percentage % symbol and interpret these as percentage of absolute value when calculating resource limits.

@simonwo simonwo added type/enhancement Type: New features or enhancements to existing features good first issue Good for newcomers station labels Apr 15, 2023
@simonwo simonwo assigned simonwo and unassigned simonwo Apr 19, 2023
@simonwo simonwo self-assigned this Apr 26, 2023
@simonwo simonwo removed their assignment Jul 3, 2023
@wdbaruni wdbaruni removed the station label Apr 18, 2024
@wdbaruni
Copy link
Member

wdbaruni commented Jul 1, 2024

@wdbaruni wdbaruni added this to the v1.5.0 milestone Jul 1, 2024
@wdbaruni wdbaruni moved this from Inbox to Next in Engineering Planning Jul 1, 2024
@wdbaruni wdbaruni added the th/config Theme: Related to configuration files and settings across the project label Jul 1, 2024
@wdbaruni wdbaruni closed this as completed Oct 8, 2024
@github-project-automation github-project-automation bot moved this from Next to Done in Engineering Planning Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers th/config Theme: Related to configuration files and settings across the project type/enhancement Type: New features or enhancements to existing features
Projects
Status: Done
Development

No branches or pull requests

3 participants