fix: don't warn when node name is empty (#4446)

frrist · frrist · web-flow · commit d0bae630ab23 · 2024-09-17T15:23:13.000-07:00
- fixes #4430 Co-authored-by: frrist <forrest@expanso.io>
diff --git a/cmd/cli/serve/serve.go b/cmd/cli/serve/serve.go
@@ -144,7 +144,7 @@ func serve(cmd *cobra.Command, cfg types.Bacalhau, fsRepo *repo.FsRepo) error {
 
 	} else {
 		// Warn if the flag was provided but node name already exists
-		if flagNodeName := cmd.PersistentFlags().Lookup(NameFlagName).Value.String(); flagNodeName != nodeName {
+		if flagNodeName := cmd.PersistentFlags().Lookup(NameFlagName).Value.String(); flagNodeName != "" && flagNodeName != nodeName {
 			log.Warn().Msgf("--name flag with value %s ignored. Name %s already exists", flagNodeName, nodeName)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ func serve(cmd cobra.Command, cfg types.Bacalhau, fsRepo repo.FsRepo) error {`
`144`	`144`
`145`	`145`	`} else {`
`146`	`146`	`// Warn if the flag was provided but node name already exists`
`147`		`- if flagNodeName := cmd.PersistentFlags().Lookup(NameFlagName).Value.String(); flagNodeName != nodeName {`
	`147`	`+ if flagNodeName := cmd.PersistentFlags().Lookup(NameFlagName).Value.String(); flagNodeName != "" && flagNodeName != nodeName {`
`148`	`148`	`log.Warn().Msgf("--name flag with value %s ignored. Name %s already exists", flagNodeName, nodeName)`
`149`	`149`	`}`
`150`	`150`	`}`