Skip to content

Commit 980a143

Browse files
committed
WIP: Apply better naming
1 parent d42a7ff commit 980a143

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

.github/workflows/build.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Build Binaries
1+
name: Build Bacalhau Binaries
22

33
on:
44
workflow_call:
@@ -33,7 +33,7 @@ jobs:
3333

3434
- uses: actions/checkout@v4
3535
with:
36-
fetch-depth: "0"
36+
fetch-depth: "0" # Need to fetch all due to how bacalhau constructs semver
3737

3838
- uses: actions/setup-go@v5
3939
with:
@@ -59,13 +59,16 @@ jobs:
5959
# Listing Builds
6060
echo "===> Built Artifacts:"
6161
ls -lh dist/
62+
63+
# Remove keys, good security practice
64+
rm /tmp/private.pem /tmp/public.pem
6265
6366
- name: Upload binary artifacts
6467
uses: actions/upload-artifact@v4
6568
with:
6669
name: ${{ matrix.os }}-${{ matrix.goarch }}
6770
path: "dist/bacalhau_*"
68-
retention-days: 1 # Short retention since these are intermediate artifacts
71+
retention-days: 1 # Short retention since these are intermediate artifacts, also save money
6972

7073
- name: Report build status
7174
if: always()

.github/workflows/ci.yml .github/workflows/pipeline-main.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: CI Pipeline
1+
name: Main Pipeline
22

33
on:
44
push:
@@ -13,10 +13,10 @@ jobs:
1313
uses: ./.github/workflows/build.yml
1414
secrets: inherit
1515

16-
integration-tests:
16+
testcontainers-suite:
1717
needs: build
1818
if: success()
19-
uses: ./.github/workflows/testcontainers-integration-tests.yml
19+
uses: ./.github/workflows/testcontainers-suite.yml
2020
with:
2121
os: linux
2222
arch: amd64

.github/workflows/testcontainers-integration-tests.yml .github/workflows/testcontainers-suite.yml

+6-9
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: TestContainers Testing
1+
name: TestContainers Suite
22

33
on:
44
workflow_call:
@@ -21,7 +21,7 @@ jobs:
2121
uses: actions/download-artifact@v4
2222
with:
2323
name: ${{ inputs.os }}-${{ inputs.arch }}
24-
path: tmp/
24+
path: compiled-artifacts/
2525

2626
- name: Install Golang
2727
uses: actions/setup-go@v5
@@ -31,14 +31,11 @@ jobs:
3131
- name: Run Go tests in integration test directory
3232
shell: bash
3333
run: |
34-
# TODO: make WebUI happy when compiling
35-
mkdir -p webui/build
36-
echo "hello test" > webui/build/index.html
37-
echo "===> Copy binary to tests assets"
38-
cd tmp
34+
echo "===> Copy compiled artifact to use in docker images..."
35+
cd compiled-artifacts
3936
tar -xzf bacalhau_*.tar.gz
4037
cp ./bacalhau ../test_integration/common_assets/bacalhau_bin
41-
42-
# Run tests
38+
39+
echo "===> Running tests..."
4340
cd ../test_integration
4441
go test -v -count=1 ./...

0 commit comments

Comments
 (0)