Skip to content

Commit 71a58d9

Browse files
authored
Fix TestConcurrentHealthCheckAndHeartbeat assertion (#4780)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced error handling in tests for concurrent heartbeats. - Improved assertions and validations for expected states and error messages. - **New Features** - Added new test cases for shutdown notice handling and resource management. - Included concurrency tests for simultaneous operations. - Verified lifecycle management with checks for idempotency. - Ensured state persistence during manager stop and context cancellation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent caaf92c commit 71a58d9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/orchestrator/nodes/manager_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ func (s *NodeManagerTestSuite) TestConcurrentHealthCheckAndHeartbeat() {
485485
})
486486
// Either succeed or fail with concurrent update error
487487
if err != nil {
488-
assert.Contains(s.T(), err.Error(), "concurrent update conflict")
488+
s.True(bacerrors.IsErrorWithCode(err, nodes.ConcurrentUpdate))
489489
}
490490
}()
491491
}

0 commit comments

Comments
 (0)