Skip to content

Commit

Permalink
Fix TestConcurrentHealthCheckAndHeartbeat assertion (#4780)
Browse files Browse the repository at this point in the history
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
	- Enhanced error handling in tests for concurrent heartbeats.
- Improved assertions and validations for expected states and error
messages.

- **New Features**
- Added new test cases for shutdown notice handling and resource
management.
	- Included concurrency tests for simultaneous operations.
	- Verified lifecycle management with checks for idempotency.
- Ensured state persistence during manager stop and context
cancellation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
wdbaruni authored Dec 18, 2024
1 parent caaf92c commit 71a58d9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/orchestrator/nodes/manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ func (s *NodeManagerTestSuite) TestConcurrentHealthCheckAndHeartbeat() {
})
// Either succeed or fail with concurrent update error
if err != nil {
assert.Contains(s.T(), err.Error(), "concurrent update conflict")
s.True(bacerrors.IsErrorWithCode(err, nodes.ConcurrentUpdate))
}
}()
}
Expand Down

0 comments on commit 71a58d9

Please sign in to comment.