Skip to content

Commit 65f7a03

Browse files
committed
Minor improvements for integration tests.
Linear issue tracker: https://linear.app/expanso/issue/ENG-263/explore-testcontainers-to-utilize-in-testing-strategy Github Issue: #4597
1 parent b411ed5 commit 65f7a03

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

test_integration/base_suite_test.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ func (s *BaseDockerComposeTestSuite) waitForJobToComplete(jobID string, timeout
233233
return time.Since(startTime), nil
234234
}
235235

236-
time.Sleep(1000 * time.Millisecond)
236+
time.Sleep(time.Second)
237237
}
238238

239239
return timeout, fmt.Errorf("job did not finish within allowed time limit %s", timeout.String())
@@ -242,29 +242,29 @@ func (s *BaseDockerComposeTestSuite) waitForJobToComplete(jobID string, timeout
242242
func (s *BaseDockerComposeTestSuite) renderDockerComposeFile(inputFilePath string, tmpDir string, imageReplacements map[string]string) (string, error) {
243243
data, err := os.ReadFile(inputFilePath)
244244
if err != nil {
245-
return "", fmt.Errorf("error reading file: %v", err)
245+
return "", fmt.Errorf("error reading file: %w", err)
246246
}
247247

248248
var node yaml.Node
249249
err = yaml.Unmarshal(data, &node)
250250
if err != nil {
251-
return "", fmt.Errorf("error parsing YAML: %v", err)
251+
return "", fmt.Errorf("error parsing YAML: %w", err)
252252
}
253253

254254
err = modifyImageNamesInDockerComposeFile(&node, imageReplacements)
255255
if err != nil {
256-
return "", fmt.Errorf("error modifying image names: %v", err)
256+
return "", fmt.Errorf("error modifying image names: %w", err)
257257
}
258258

259259
modifiedYAML, err := yaml.Marshal(&node)
260260
if err != nil {
261-
return "", fmt.Errorf("error marshaling YAML: %v", err)
261+
return "", fmt.Errorf("error marshaling YAML: %w", err)
262262
}
263263

264264
tmpFile := filepath.Join(tmpDir, "rendered-docker-compose.yml")
265265
err = os.WriteFile(tmpFile, modifiedYAML, 0644)
266266
if err != nil {
267-
return "", fmt.Errorf("error writing file: %v", err)
267+
return "", fmt.Errorf("error writing file: %w", err)
268268
}
269269

270270
return tmpFile, nil

test_integration/test_utils.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ func extractJobIDFromOutput(jobRunOutput string, s *suite.Suite) string {
300300
s.Require().Regexpf(
301301
`Job successfully submitted\. Job ID: j-[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}`,
302302
jobRunOutput,
303-
"JOb output did not signal a successful job submission: %q",
303+
"Job output did not signal a successful job submission: %q",
304304
jobRunOutput,
305305
)
306306

0 commit comments

Comments
 (0)