Different defrecords with same fields are equal

[frenchy64]

version

Via Babashka v0.8.2 REPL

platform

Via Babashka v0.8.2 REPL
Intel Mac

problem

Different defrecords with same fields are equal. Causes this schema unit test to fail, since the schema implementation defines:

(clojure.core/defrecord RequiredKey [k])
(clojure.core/defrecord OptionalKey [k])

repro

Babashka v0.8.2 REPL.
Use :repl/quit or :repl/exit to quit the REPL.
Clojure rocks, Bash reaches.

user=> (defrecord A [a])
#'user/A
user=> (defrecord B [a])
#'user/B
user=> (= (A. 1) (B. 1))
true

expected behavior

Clojure 1.11.1
user=> (defrecord A [a])
user.A
user=> (defrecord B [a])
user.B
user=> (= (A. 1) (B. 1))
false

[borkdude]

Related: #727

[borkdude]

Working on a fix by adding a field __sci_type which is different for each record, but this breaks existing libraries that babashka runs in CI:

{:test 1785, :pass 10291, :fail 7, :error 2}

We probably need to move on to a custom record implementation to make this work properly...

[borkdude]

Got all tests passing now in branch with a custom record implementation, at least in the :clj side of things! In babashka branch record-equiv.

[frenchy64]

We probably need to move on to a custom record implementation to make this work properly...

+1