Drop name metadata from conditionally defined var

Author: borkdude

CHANGELOG.md

@@ -7,6 +7,7 @@ For a list of breaking changes, check [here](#breaking-changes)
 - Fix [#817](https://github.com/babashka/sci/issues/817): mutation of `deftype` field should be visible in protocol method
 - Fix [#816](https://github.com/babashka/sci/issues/816): restore recur target exception in do
 - Fix [#819](https://github.com/babashka/sci/issues/819): don't use metadata in record implementation
+- Drop name metadata from conditionally defined var
 
 ## v0.5.34 (2022-10-18)
 

src/sci/impl/analyzer.cljc

@@ -669,10 +669,9 @@
                            (assoc the-current-ns name
                                   (doto (sci.lang.Var. nil (symbol (str cnn)
                                                                    (str name))
-                                                       (assoc (meta name)
-                                                              :name name
-                                                              :ns @utils/current-ns
-                                                              :file @utils/current-file)
+                                                       {:name name
+                                                        :ns @utils/current-ns
+                                                        :file @utils/current-file}
                                                        false
                                                        false)
                                     (vars/unbind)))

test/sci/core_test.cljc

@@ -1614,6 +1614,10 @@
 (deftest type-test
   (is (= :user/foo (sci/eval-string "(def x ^{:type ::foo} []) (type x)"))))
 
+(deftest conditional-var-test
+  ;; NOTE: :file is not conform Clojure JVM, maybe fix this another day
+  (is (= [:name :ns :file] (sci/eval-string "(when false (def ^:foobar x)) (keys (meta #'x))"))))
+
 ;;;; Scratch
 
 (comment