Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add searchbar #231

Closed
wants to merge 2 commits into from
Closed

docs: add searchbar #231

wants to merge 2 commits into from

Conversation

yujonglee
Copy link

Description

Resolves #224.

It use Pagefind to create local search index at build-time, and use Canary to build SearchBar UI.

Screen.Recording.2024-08-26.at.12.36.49.PM.mov

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
  • Read contribution guidelines.

@azat-io
Copy link
Owner

azat-io commented Aug 27, 2024

Wow. It looks nice. Let's fix linter errors and I'll see it.

@yujonglee
Copy link
Author

@azat-io I guess this is ready for review. not sure why CI is not triggered.

@azat-io
Copy link
Owner

azat-io commented Aug 28, 2024

Could you resolve merge conflicts?

@yujonglee
Copy link
Author

@azat-io just did!

@yujonglee
Copy link
Author

@azat-io anything I could do to help get this merged in?

@azat-io
Copy link
Owner

azat-io commented Sep 8, 2024

Screen Recording 2024-09-08 at 12 42 46 PM

@yujonglee Hello! I tried to start your branch locally. And it seems that the search not working for me.

I'm also a bit confused by the design. I'd like to customize it a bit. Take the search icon from the common icon library. And stylize the search input a bit.

@yujonglee
Copy link
Author

@azat-io Thank you for trying it out.

I guess you ran pnpm run docs:dev. But astro-pagefind only generate index in production build. That's why it can not find index and search not work for you.

[404] /pagefind/pagefind.js 3ms

If you run pnpm run docs:build at least once, it will create index, and search will work ``pnpm run docs:dev`. Sorry that I didn't mentioned it earlier.

[pagefind] Pagefind indexed 31 pages
[pagefind] Pagefind wrote index to eslint-plugin-perfectionist/dist/pagefind

Regarding styling & customization, it is very important goal for me to make these components easy to customize. So I would love to hear more about which part of design was confusing for you.

We have docs about the styling here:

https://getcanary.dev/docs/common/customization/styling

For things you mentioned -

And stylize the search input a bit.

https://github.com/fastrepl/canary/blob/590fc07d4a2a20d3193d6f7e57c3d28976b9dde1/js/packages/web/src/components/canary-search-input.ts#L39

  canary-search-input::part(input) {
    background-color: red;
  }

Take the search icon from the common icon library.

https://github.com/fastrepl/canary/blob/590fc07d4a2a20d3193d6f7e57c3d28976b9dde1/js/packages/web/src/components/canary-search.ts#L36-L38

 ...
 <canary-search-input slot="input">
   // plug your icon component and override the default
  <common-icon-lib slot="input-before"></common-icon-lib >
</canary-search-input>
...

Any customization should be doable, if Canary expose them with slot and part. Would appreciate if there's anything missing for your use-case.

Thank you.

Repository owner deleted a comment from sonarqubecloud bot Dec 3, 2024
@yujonglee yujonglee closed this Dec 4, 2024
@yujonglee yujonglee deleted the search branch December 4, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Website search
2 participants