-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add searchbar #231
docs: add searchbar #231
Conversation
Wow. It looks nice. Let's fix linter errors and I'll see it. |
@azat-io I guess this is ready for review. not sure why CI is not triggered. |
Could you resolve merge conflicts? |
@azat-io just did! |
@azat-io anything I could do to help get this merged in? |
@yujonglee Hello! I tried to start your branch locally. And it seems that the search not working for me. I'm also a bit confused by the design. I'd like to customize it a bit. Take the search icon from the common icon library. And stylize the search input a bit. |
@azat-io Thank you for trying it out. I guess you ran
If you run
Regarding styling & customization, it is very important goal for me to make these components easy to customize. So I would love to hear more about which part of design was confusing for you. We have docs about the styling here: https://getcanary.dev/docs/common/customization/styling For things you mentioned -
canary-search-input::part(input) {
background-color: red;
}
...
<canary-search-input slot="input">
// plug your icon component and override the default
<common-icon-lib slot="input-before"></common-icon-lib >
</canary-search-input>
... Any customization should be doable, if Canary expose them with Thank you. |
Description
Resolves #224.
It use Pagefind to create local search index at build-time, and use Canary to build SearchBar UI.
Screen.Recording.2024-08-26.at.12.36.49.PM.mov
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).