fix: allow overriding settings with default values

azat-io · web-flow · commit 08d69caec54e · 2025-12-23T00:16:59.000+03:00
diff --git a/eslint.config.ts b/eslint.config.ts
@@ -4,7 +4,14 @@ import eslintPlugin from 'eslint-plugin-eslint-plugin'
 import eslintConfig from '@azat-io/eslint-config'
 
 export default eslintConfig({
-  extends: eslintPlugin.configs.recommended,
+  extends: [
+    eslintPlugin.configs.recommended,
+    {
+      rules: {
+        'eslint-plugin/require-meta-default-options': 'off',
+      },
+    },
+  ],
   perfectionist: true,
   typescript: true,
   svelte: true,
diff --git a/rules/sort-array-includes.ts b/rules/sort-array-includes.ts
@@ -136,7 +136,6 @@ export default createEslintRule<Options, MessageId>({
       url: 'https://perfectionist.dev/rules/sort-array-includes',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     schema: jsonSchema,
     type: 'suggestion',
     fixable: 'code',
diff --git a/rules/sort-classes.ts b/rules/sort-classes.ts
@@ -675,7 +675,6 @@ export default createEslintRule<SortClassesOptions, MessageId>({
       description: 'Enforce sorted classes.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-decorators.ts b/rules/sort-decorators.ts
@@ -122,7 +122,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted decorators.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-enums.ts b/rules/sort-enums.ts
@@ -261,7 +261,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted TypeScript enums.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-export-attributes.ts b/rules/sort-export-attributes.ts
@@ -193,7 +193,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted export attributes.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-exports.ts b/rules/sort-exports.ts
@@ -202,7 +202,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted exports.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-heritage-clauses.ts b/rules/sort-heritage-clauses.ts
@@ -88,7 +88,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted heritage clauses.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-import-attributes.ts b/rules/sort-import-attributes.ts
@@ -193,7 +193,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted import attributes.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-imports.ts b/rules/sort-imports.ts
@@ -344,7 +344,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted imports.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-interfaces.ts b/rules/sort-interfaces.ts
@@ -39,7 +39,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted interface properties.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     schema: jsonSchema,
     type: 'suggestion',
     fixable: 'code',
diff --git a/rules/sort-intersection-types.ts b/rules/sort-intersection-types.ts
@@ -51,7 +51,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted intersection types.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     schema: jsonSchema,
     type: 'suggestion',
     fixable: 'code',
diff --git a/rules/sort-jsx-props.ts b/rules/sort-jsx-props.ts
@@ -245,7 +245,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted JSX props.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-maps.ts b/rules/sort-maps.ts
@@ -232,7 +232,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted Map elements.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-modules.ts b/rules/sort-modules.ts
@@ -125,7 +125,6 @@ export default createEslintRule<SortModulesOptions, MessageId>({
       description: 'Enforce sorted modules.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-named-exports.ts b/rules/sort-named-exports.ts
@@ -214,7 +214,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted named exports.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-named-imports.ts b/rules/sort-named-imports.ts
@@ -219,7 +219,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted named imports.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-object-types.ts b/rules/sort-object-types.ts
@@ -128,6 +128,20 @@ export let jsonSchema: JSONSchema4 = {
 }
 
 export default createEslintRule<Options, MessageId>({
+  create: context => ({
+    TSTypeLiteral: node =>
+      sortObjectTypeElements<MessageId>({
+        availableMessageIds: {
+          missedSpacingBetweenMembers: MISSED_SPACING_ERROR_ID,
+          extraSpacingBetweenMembers: EXTRA_SPACING_ERROR_ID,
+          unexpectedGroupOrder: GROUP_ORDER_ERROR_ID,
+          unexpectedOrder: ORDER_ERROR_ID,
+        },
+        parentNodes: computeObjectTypeParentNodes(node),
+        elements: node.members,
+        context,
+      }),
+  }),
   meta: {
     messages: {
       [MISSED_SPACING_ERROR_ID]: MISSED_SPACING_ERROR,
@@ -140,25 +154,10 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted object types.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     schema: jsonSchema,
     type: 'suggestion',
     fixable: 'code',
   },
-  create: context => ({
-    TSTypeLiteral: node =>
-      sortObjectTypeElements<MessageId>({
-        availableMessageIds: {
-          missedSpacingBetweenMembers: MISSED_SPACING_ERROR_ID,
-          extraSpacingBetweenMembers: EXTRA_SPACING_ERROR_ID,
-          unexpectedGroupOrder: GROUP_ORDER_ERROR_ID,
-          unexpectedOrder: ORDER_ERROR_ID,
-        },
-        parentNodes: computeObjectTypeParentNodes(node),
-        elements: node.members,
-        context,
-      }),
-  }),
   defaultOptions: [defaultOptions],
   name: 'sort-object-types',
 })
diff --git a/rules/sort-objects.ts b/rules/sort-objects.ts
@@ -423,7 +423,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted objects.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-sets.ts b/rules/sort-sets.ts
@@ -61,7 +61,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted sets.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     schema: jsonSchema,
     type: 'suggestion',
     fixable: 'code',
diff --git a/rules/sort-switch-case.ts b/rules/sort-switch-case.ts
@@ -285,7 +285,6 @@ export default createEslintRule<Options, MessageId>({
     messages: {
       [ORDER_ERROR_ID]: ORDER_ERROR,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/rules/sort-union-types.ts b/rules/sort-union-types.ts
@@ -99,7 +99,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted union types.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     schema: jsonSchema,
     type: 'suggestion',
     fixable: 'code',
diff --git a/rules/sort-variable-declarations.ts b/rules/sort-variable-declarations.ts
@@ -234,7 +234,6 @@ export default createEslintRule<Options, MessageId>({
       description: 'Enforce sorted variable declarations.',
       recommended: true,
     },
-    defaultOptions: [defaultOptions],
     type: 'suggestion',
     fixable: 'code',
   },
diff --git a/utils/complete.ts b/utils/complete.ts
@@ -32,98 +32,5 @@ export function complete<T extends Record<string, unknown>>(
   settings: Settings = {},
   defaults: T = {} as T,
 ): T {
-  let strippedOptions = stripDefaultValues(
-    options as Record<string, unknown>,
-    defaults as Record<string, unknown>,
-  )
-
-  return {
-    ...defaults,
-    ...settings,
-    ...(strippedOptions as Record<string, unknown> & Partial<T>),
-  }
-}
-
-/**
- * Recursively removes properties from `options` that are identical to those in
- * `defaults`, returning a new object with only the differing properties.
- *
- * This is useful for minimizing configuration objects by stripping out default
- * values, allowing for cleaner overrides.
- *
- * @param options - The configuration object to strip defaults from.
- * @param defaults - The default configuration object to compare against.
- * @returns A new object containing only the properties from `options` that
- *   differ from `defaults`.
- */
-function stripDefaultValues(
-  options: Record<string, unknown>,
-  defaults: Record<string, unknown>,
-): Record<string, unknown> {
-  let result: Record<string, unknown> = {}
-
-  for (let key of Object.keys(options)) {
-    let optionValue = options[key]
-
-    if (!(key in defaults)) {
-      result[key] = optionValue
-      continue
-    }
-
-    let defaultValue = defaults[key]
-
-    if (isPlainObject(optionValue) && isPlainObject(defaultValue)) {
-      let nestedDiff = stripDefaultValues(optionValue, defaultValue)
-
-      if (Object.keys(nestedDiff).length > 0) {
-        result[key] = nestedDiff
-      }
-
-      continue
-    }
-
-    if (!isDeepEqual(optionValue, defaultValue)) {
-      result[key] = optionValue
-    }
-  }
-
-  return result
-}
-
-function isDeepEqual(a: unknown, b: unknown): boolean {
-  if (a === b) {
-    return true
-  }
-
-  if (Array.isArray(a) && Array.isArray(b)) {
-    if (a.length !== b.length) {
-      return false
-    }
-
-    for (let [index, element] of a.entries()) {
-      /* v8 ignore else -- @preserve Guard clause primarily for defensive programming; equality branch is impractical to hit in current unit tests. */
-      if (!isDeepEqual(element, b[index])) {
-        return false
-      }
-    }
-
-    return true
-  }
-
-  return false
-}
-
-/**
- * Checks if a value is a plain object (i.e., an object created by the Object
- * constructor or with a null prototype).
- *
- * @param value - The value to check.
- * @returns True if the value is a plain object, false otherwise.
- */
-function isPlainObject(value: unknown): value is Record<string, unknown> {
-  return (
-    typeof value === 'object' &&
-    value !== null &&
-    (value.constructor === Object || Object.getPrototypeOf(value) === null)
-  )
+  return { ...defaults, ...settings, ...options }
 }
