How to do pluralization for structs

[AnomalousUnderdog]

I have a Dice struct that I was hoping could work for the pluralization formatter:

public struct Dice
{
	public int Quantity;
	public int NumberOfSides;
	public int Bonus;

	// new Dice(2, 6, 3) means 2d6+3 meaning roll two 6-sided dice and add 3 to the result
	public Dice(int quantity, int numberOfSides, int bonus)
	{
		Quantity = quantity;
		NumberOfSides = numberOfSides;
		Bonus = bonus;
	}

	public int Min => Quantity + Bonus;
	public int Max => (Quantity * NumberOfSides) + Bonus;

	public override string ToString()
	{
		if (quantity > 0 && numberOfSides > 0)
		{
			if (bonus == 0)
			{
				// no bonus value (example: "2d6")
				return $"{quantity}d{numberOfSides}";
			}
			else
			{
				// with bonus (example: "2d6+3", or "2d6-3")
				return $"{quantity}d{numberOfSides}{bonus:+0;-#}";
			}
		}

		// bonus value only, no dice roll
		if (bonus != 0)
		{
			return bonus.ToString();
		}

		// note: negative value in dice roll ignored, treat it as zero
		return "0";
	}
}

For the purposes of discussion, ignore any nonsensical values like 1d1-100. I have code to error check those things.

I determine if a Dice value is plural by:

public bool IsPlural => Max > 1;

It doesn't matter if the lowest value it can produce is 1, the fact that it is capable of producing a value greater than 1 automatically means it's "plural".

However I notice there doesn't seem to be any way for me to inform SmartFormat when my value is plural or not. Doesn't even seem like PluralLocalizationFormatter.cs will accept anything other than a numerical value or collection.

Right now I am just using the Dice Max value, forcing me to pass two values:

Dice d = new Dice(2, 6, 3);
Smart.Format("Deal {1:plural(en):{0} point|{0} points} of damage.", d, d.Max); // "Deal 2d6+3 points of damage."

d = new Dice(0, 0, 1);
Smart.Format("Deal {1:plural(en):{0} point|{0} points} of damage.", d, d.Max); // "Deal 1 point of damage."

d = new Dice(0, 0, 2);
Smart.Format("Deal {1:plural(en):{0} point|{0} points} of damage.", d, d.Max); // "Deal 2 points of damage."

This is what I was hoping it would do:

// not possible, but should output "Deal 2d6+3 points of damage."
// gives: Error parsing format string: No suitable Formatter could be found at 19
Dice d = new Dice(2, 6, 3);
Smart.Format("Deal {0:plural(en):{} point|{} points} of damage.", d);

[axunonb]

You can't have a Dice class instance as an argument to SmartFormat without including the properties that SmartFormat should evaluate in the format string. Hope this makes the missing part clear:

using NUnit.Framework;
namespace SmartFormat.Tests.Core;

public struct Dice
{
    /*
     * Original code does not compile - casing of properties
     */

    public int Quantity;
    public int NumberOfSides;
    public int Bonus;

    // new Dice(2, 6, 3) means 2d6+3 meaning roll two 6-sided dice and add 3 to the result
    public Dice(int quantity, int numberOfSides, int bonus)
    {
        Quantity = quantity;
        NumberOfSides = numberOfSides;
        Bonus = bonus;
    }

    public int Min => Quantity + Bonus;
    public int Max => (Quantity * NumberOfSides) + Bonus;

    public override string ToString()
    {
        if (Quantity > 0 && NumberOfSides > 0)
        {
            if (Bonus == 0)
            {
                // no bonus value (example: "2d6")
                return $"{Quantity}d{NumberOfSides}";
            }
            else
            {
                // with bonus (example: "2d6+3", or "2d6-3")
                return $"{Quantity}d{NumberOfSides}{Bonus:+0;-#}";
            }
        }

        // bonus value only, no dice roll
        if (Bonus != 0) {
            return Bonus.ToString();
        }

        // note: negative value in dice roll ignored, treat it as zero
        return "0";
    }
}


[TestFixture]
public class Discussion_295
{
    [Test]  
    public void DiceTest()
    {
        var d = new Dice(2, 6, 3);
        // Note: "ToString" can be omitted - it is called implicitly, as you saw in your code sample
        var result = Smart.Format("Deal {0.Max:plural(en):{0.ToString} point|{0.ToString} points} of damage.", d); 
        // result: Deal 2d6+3 points of damage.

        d = new Dice(0, 0, 1);
        result = Smart.Format("Deal {0.Max:plural(en):{0.ToString} point|{0.ToString} points} of damage.", d);
        // result: Deal 1 point of damage.

        d = new Dice(0, 0, 2);
        result = Smart.Format("Deal {0.Max:plural(en):{0.ToString} point|{0.ToString} points} of damage.", d);
        // result: Deal 2 points of damage.
    }
}

[AnomalousUnderdog]

Thanks. I didn't know it could access the struct's properties that way. I was hoping to have it implicitly call a method like some sort of ToInteger in the same way you mention that ToString can be omitted.

Something like an interface that the Plural Formatter could check for?

public interface IToInteger
{
	int ToInteger();
}

[axunonb]

While ToString() is a very common overloaded method for classes, that even exists for object, it would be difficult to implement more implicit conversions.

[AnomalousUnderdog]

I didn't mean to implicitly convert anything to int, but for the PluralLocalizationFormatter to implicitly call ToInteger() for anything that implements that rhetorical IToInteger interface. Anyway I hacked it in and it only took a few lines and I'm quite happy with it, thanks.

            if (current is byte or short or ushort or int or uint  or long or ulong or float or double or decimal)
                value = Convert.ToDecimal(current);
+           else if (current is IToInteger i)
+               value = i.ToInteger();
            else if (current is IEnumerable<object> objects)
                value = objects.Count();