major bug fix in BufferedFluentMetric.flush #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this wasted 2 days of my time assuming cloudwatch is dropping metrics when it was this bug here. it seems you haven't even tested your code with more than 20 metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this wasted 2 days of my time assuming cloudwatch is dropping metrics when it was this bug here. it seems you haven't even tested your code with more than 20 metrics.
Issue #, if available:
when there are more than
PAGE_SIZEmetrics in the buffer, andBufferedFluentMetric.flushis called withsend_partial=True, it will not send the remaining metrics because of a bug in the way "end" is calculated. It would only work if you have less than 20 metrics in the buffer. If there are 23 (or 63) for example, it would never send the remaining 3.Description of changes:
endshould bestart+(len(buffer) % PAGE_SIZE)and not just(len(buffer) % PAGE_SIZE)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.