From cedc2f44c98cf815819ba617f55b92b7433f548e Mon Sep 17 00:00:00 2001 From: Waqar Ahmed Khan Date: Fri, 18 Oct 2024 09:30:50 -0700 Subject: [PATCH 1/4] remove test --- crt/aws-c-common | 2 +- crt/aws-c-io | 2 +- crt/aws-c-mqtt | 2 +- crt/aws-c-s3 | 2 +- crt/aws-lc | 2 +- crt/s2n | 2 +- test/test_s3.py | 4 ---- 7 files changed, 6 insertions(+), 10 deletions(-) diff --git a/crt/aws-c-common b/crt/aws-c-common index b9959f592..f58e807d8 160000 --- a/crt/aws-c-common +++ b/crt/aws-c-common @@ -1 +1 @@ -Subproject commit b9959f5922a4b969beab8f0b99aa0b34bc9ee55c +Subproject commit f58e807d8fd643bd9a96eef182c1db37d01b88e7 diff --git a/crt/aws-c-io b/crt/aws-c-io index c345d7727..e36374047 160000 --- a/crt/aws-c-io +++ b/crt/aws-c-io @@ -1 +1 @@ -Subproject commit c345d77274db83c0c2e30331814093e7c84c45e2 +Subproject commit e36374047beadc72a0eb6df14ce3cbc822a789a3 diff --git a/crt/aws-c-mqtt b/crt/aws-c-mqtt index c43232c1b..77d6f00e8 160000 --- a/crt/aws-c-mqtt +++ b/crt/aws-c-mqtt @@ -1 +1 @@ -Subproject commit c43232c1bc378344bb7245d7fcb167410f3fe931 +Subproject commit 77d6f00e89b10e3263d8a17576ec8e91c45b4606 diff --git a/crt/aws-c-s3 b/crt/aws-c-s3 index aede1d8c2..16701501f 160000 --- a/crt/aws-c-s3 +++ b/crt/aws-c-s3 @@ -1 +1 @@ -Subproject commit aede1d8c24f9f580d5a96c089878e9b258b88d04 +Subproject commit 16701501fa9d1684b0ff5406211d058ce2a5b404 diff --git a/crt/aws-lc b/crt/aws-lc index d3a598c1b..8ffe277c2 160000 --- a/crt/aws-lc +++ b/crt/aws-lc @@ -1 +1 @@ -Subproject commit d3a598c1b419d49b5b08f0677add4581572e2edc +Subproject commit 8ffe277c21915ca82dc78a3bdc6a92e10c284b92 diff --git a/crt/s2n b/crt/s2n index 08d413a0b..ffe0bf42d 160000 --- a/crt/s2n +++ b/crt/s2n @@ -1 +1 @@ -Subproject commit 08d413a0b9b3226e775a38f04e3cf02230cc97c4 +Subproject commit ffe0bf42da8f139eff8fd2237f47fbde40b478fb diff --git a/test/test_s3.py b/test/test_s3.py index ddde60aaa..7a0b966b7 100644 --- a/test/test_s3.py +++ b/test/test_s3.py @@ -221,10 +221,6 @@ def test_sanity_secure(self): s3_client = s3_client_new(True, self.region) self.assertIsNotNone(s3_client) - def test_sanity_network_interface_names(self): - s3_client = s3_client_new(True, self.region, network_interface_names=("eth0", "eth1")) - self.assertIsNotNone(s3_client) - def test_wait_shutdown(self): s3_client = s3_client_new(False, self.region) self.assertIsNotNone(s3_client) From eb185da8b730af636b130a2a5349d481705f9147 Mon Sep 17 00:00:00 2001 From: Waqar Ahmed Khan Date: Fri, 18 Oct 2024 09:32:07 -0700 Subject: [PATCH 2/4] assert IsNone --- test/test_s3.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/test_s3.py b/test/test_s3.py index 7a0b966b7..cbf9d2e93 100644 --- a/test/test_s3.py +++ b/test/test_s3.py @@ -221,6 +221,10 @@ def test_sanity_secure(self): s3_client = s3_client_new(True, self.region) self.assertIsNotNone(s3_client) + def test_sanity_network_interface_names(self): + s3_client = s3_client_new(True, self.region, network_interface_names=("eth0", "invalid-network-interface")) + self.assertIsNone(s3_client) + def test_wait_shutdown(self): s3_client = s3_client_new(False, self.region) self.assertIsNotNone(s3_client) From af839f059c7989762ae68fc18f76b8da3987456a Mon Sep 17 00:00:00 2001 From: Waqar Ahmed Khan Date: Fri, 18 Oct 2024 09:39:44 -0700 Subject: [PATCH 3/4] assert raises --- test/test_s3.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test_s3.py b/test/test_s3.py index cbf9d2e93..0fbf444f5 100644 --- a/test/test_s3.py +++ b/test/test_s3.py @@ -222,8 +222,8 @@ def test_sanity_secure(self): self.assertIsNotNone(s3_client) def test_sanity_network_interface_names(self): - s3_client = s3_client_new(True, self.region, network_interface_names=("eth0", "invalid-network-interface")) - self.assertIsNone(s3_client) + with self.assertRaises(Exception): + s3_client_new(True, self.region, network_interface_names=("eth0", "invalid-network-interface")) def test_wait_shutdown(self): s3_client = s3_client_new(False, self.region) From b46e587926285dcf6c7a7e33e581ad51189c14e5 Mon Sep 17 00:00:00 2001 From: Waqar Ahmed Khan Date: Fri, 18 Oct 2024 15:12:29 -0700 Subject: [PATCH 4/4] comment --- test/test_s3.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_s3.py b/test/test_s3.py index 0fbf444f5..2ff069208 100644 --- a/test/test_s3.py +++ b/test/test_s3.py @@ -222,6 +222,7 @@ def test_sanity_secure(self): self.assertIsNotNone(s3_client) def test_sanity_network_interface_names(self): + # This is just a sanity test to ensure that we are passing the parameter correctly. with self.assertRaises(Exception): s3_client_new(True, self.region, network_interface_names=("eth0", "invalid-network-interface"))