From 07344310ca36c42d8865d6262994d7562dbba53b Mon Sep 17 00:00:00 2001 From: Steve Kim Date: Thu, 15 Aug 2024 08:09:55 -0700 Subject: [PATCH] remove expected exception when sending a frame after websocket closes part of test_send_frame_exceptions test --- test/test_websocket.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/test_websocket.py b/test/test_websocket.py index 17de0a92d..a38703901 100644 --- a/test/test_websocket.py +++ b/test/test_websocket.py @@ -484,10 +484,13 @@ def bad_completion_callback(data): # wait for shutdown... handler.shutdown_future.result(TIMEOUT) + # Change in this PR in aws-c-io https://github.com/awslabs/aws-c-io/pull/650 + # along with this PR in aws-c-http https://github.com/awslabs/aws-c-http/pull/474 + # allows a window update during shutdown. # shouldn't be able to send frame after websocket closes - with self.assertRaises(Exception) as raises: - handler.websocket.send_frame(Opcode.TEXT, "asdf") - self.assertIn("AWS_ERROR_HTTP_WEBSOCKET_CLOSE_FRAME_SENT", str(raises.exception)) + # with self.assertRaises(Exception) as raises: + # handler.websocket.send_frame(Opcode.TEXT, "asdf") + # self.assertIn("AWS_ERROR_HTTP_WEBSOCKET_CLOSE_FRAME_SENT", str(raises.exception)) self.assertIsNone(handler.exception)