Skip to content

Commit b7aba4f

Browse files
committed
update
Signed-off-by: Junpu Fan <[email protected]>
1 parent 925fb0e commit b7aba4f

File tree

6 files changed

+86
-86
lines changed

6 files changed

+86
-86
lines changed

.github/workflows/pr-sglang.yml

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ env:
2828

2929
jobs:
3030
pr-validation:
31-
uses: ./.github/workflows/reusable/pr-validation.yml
31+
uses: ./.github/workflows/reusable-pr-validation.yml
3232
with:
3333
workflow-id: ${{ github.event.pull_request.number }}
3434
concurrency-group: "${{ github.workflow }}-pr-validation"
@@ -47,7 +47,7 @@ jobs:
4747
test-change:
4848
- "test/sglang/**"
4949
50-
read_input:
50+
setup-variables:
5151
runs-on: ubuntu-latest
5252
needs: [pr-validation]
5353
outputs:
@@ -76,23 +76,23 @@ jobs:
7676
# =============== SGLang SageMaker jobs ================
7777
# ======================================================
7878
build-sglang-image:
79-
needs: [pr-validation, read_input]
79+
needs: [pr-validation, setup-variables]
8080
if: needs.pr-validation.outputs.build-change == 'true'
81-
uses: ./.github/workflows/reusable/build-container-image.yml
81+
uses: ./.github/workflows/reusable-build-container-image.yml
8282
with:
8383
image-name: "ci"
84-
image-tag: "sglang-${{ needs.read_input.outputs.sglang-version }}-gpu-${{ needs.read_input.outputs.python-version }}-${{ needs.read_input.outputs.cuda-version }}-${{ needs.read_input.outputs.os-version }}-sagemaker-pr-${{ github.event.pull_request.number }}"
84+
image-tag: "sglang-${{ needs.setup-variables.outputs.sglang-version }}-gpu-${{ needs.setup-variables.outputs.python-version }}-${{ needs.setup-variables.outputs.cuda-version }}-${{ needs.setup-variables.outputs.os-version }}-sagemaker-pr-${{ github.event.pull_request.number }}"
8585
dockerfile-path: "docker/sglang/Dockerfile"
8686
build-context: "."
8787
build-target: "sglang-sagemaker"
88-
base-image: "lmsysorg/sglang:v${{ needs.read_input.outputs.sglang-version }}-${{ needs.read_input.outputs.cuda-version }}-amd64"
88+
base-image: "lmsysorg/sglang:v${{ needs.setup-variables.outputs.sglang-version }}-${{ needs.setup-variables.outputs.cuda-version }}-amd64"
8989
build-args: |
9090
{
9191
"CACHE_REFRESH": "${{ github.run_number }}",
92-
"BASE_IMAGE": "lmsysorg/sglang:v${{ needs.read_input.outputs.sglang-version }}-${{ needs.read_input.outputs.cuda-version }}-amd64",
93-
"CONTAINER_TYPE": "${{ needs.read_input.outputs.container-type }}",
94-
"FRAMEWORK": "${{ needs.read_input.outputs.framework }}",
95-
"FRAMEWORK_VERSION": "${{ needs.read_input.outputs.sglang-version }}"
92+
"BASE_IMAGE": "lmsysorg/sglang:v${{ needs.setup-variables.outputs.sglang-version }}-${{ needs.setup-variables.outputs.cuda-version }}-amd64",
93+
"CONTAINER_TYPE": "${{ needs.setup-variables.outputs.container-type }}",
94+
"FRAMEWORK": "${{ needs.setup-variables.outputs.framework }}",
95+
"FRAMEWORK_VERSION": "${{ needs.setup-variables.outputs.sglang-version }}"
9696
}
9797
workflow-id: ${{ github.event.pull_request.number }}
9898
runs-on: '["codebuild-runner-${{ github.run_id }}-${{ github.run_attempt }}", "fleet:x86-build-runner", "buildspec-override:true"]'
@@ -110,13 +110,13 @@ jobs:
110110
AWS_REGION: ${{ vars.AWS_REGION }}
111111

112112
set-test-environment:
113-
needs: [pr-validation, read_input, build-sglang-image]
114-
uses: ./.github/workflows/reusable/set-test-environment.yml
113+
needs: [pr-validation, setup-variables, build-sglang-image]
114+
uses: ./.github/workflows/reusable-set-test-environment.yml
115115
with:
116116
environment-name: "sglang"
117117
build-job-result: ${{ needs.build-sglang-image.result }}
118118
ci-image-uri: ${{ needs.build-sglang-image.outputs.image-uri }}
119-
prod-image-name: ${{ needs.read_input.outputs.prod-sagemaker-image }}
119+
prod-image-name: ${{ needs.setup-variables.outputs.prod-sagemaker-image }}
120120
workflow-id: ${{ github.event.pull_request.number }}
121121
change-conditions: '["${{ needs.pr-validation.outputs.build-change }}", "${{ needs.pr-validation.outputs.test-change }}"]'
122122
concurrency-group: "${{ github.workflow }}-set-test-environment"
@@ -127,9 +127,9 @@ jobs:
127127
AWS_REGION: ${{ vars.AWS_REGION }}
128128

129129
sglang-local-benchmark-test:
130-
needs: [read_input, set-test-environment, build-sglang-image]
130+
needs: [setup-variables, set-test-environment, build-sglang-image]
131131
if: success()
132-
uses: ./.github/workflows/reusable/test-execution.yml
132+
uses: ./.github/workflows/reusable-test-execution.yml
133133
with:
134134
test-name: "sglang-local-benchmark"
135135
test-category: "benchmark"
@@ -144,15 +144,15 @@ jobs:
144144
concurrency-group: "${{ github.workflow }}-sglang-local-benchmark-test"
145145
concurrency-cancel-in-progress: true
146146
container-gpus: "all"
147-
container-volumes: '["${HOME}/.cache/huggingface:/root/.cache/huggingface", "${{ needs.read_input.outputs.test-artifacts-directory }}/dataset:/dataset"]'
147+
container-volumes: '["${HOME}/.cache/huggingface:/root/.cache/huggingface", "${{ needs.setup-variables.outputs.test-artifacts-directory }}/dataset:/dataset"]'
148148
container-ports: '["30000:30000"]'
149149
container-environment: '["SM_SGLANG_MODEL_PATH=Qwen/Qwen3-0.6B", "SM_SGLANG_REASONING_PARSER=qwen3", "SM_SGLANG_HOST=127.0.0.1", "SM_SGLANG_PORT=30000"]'
150150
container-environment-secrets: '["HF_TOKEN"]'
151151
pre-setup-commands: |
152-
mkdir -p ${{ needs.read_input.outputs.test-artifacts-directory }}/dataset
153-
if [ ! -f ${{ needs.read_input.outputs.test-artifacts-directory }}/dataset/ShareGPT_V3_unfiltered_cleaned_split.json ]; then
152+
mkdir -p ${{ needs.setup-variables.outputs.test-artifacts-directory }}/dataset
153+
if [ ! -f ${{ needs.setup-variables.outputs.test-artifacts-directory }}/dataset/ShareGPT_V3_unfiltered_cleaned_split.json ]; then
154154
echo "Downloading ShareGPT dataset..."
155-
wget -P ${{ needs.read_input.outputs.test-artifacts-directory }}/dataset https://huggingface.co/datasets/anon8231489123/ShareGPT_Vicuna_unfiltered/resolve/main/ShareGPT_V3_unfiltered_cleaned_split.json
155+
wget -P ${{ needs.setup-variables.outputs.test-artifacts-directory }}/dataset https://huggingface.co/datasets/anon8231489123/ShareGPT_Vicuna_unfiltered/resolve/main/ShareGPT_V3_unfiltered_cleaned_split.json
156156
else
157157
echo "ShareGPT dataset already exists. Skipping download."
158158
fi
@@ -170,9 +170,9 @@ jobs:
170170
AWS_REGION: ${{ vars.AWS_REGION }}
171171

172172
sglang-frontend-test:
173-
needs: [read_input, build-sglang-image, set-test-environment]
173+
needs: [setup-variables, build-sglang-image, set-test-environment]
174174
if: success()
175-
uses: ./.github/workflows/reusable/test-execution.yml
175+
uses: ./.github/workflows/reusable-test-execution.yml
176176
with:
177177
test-name: "sglang-frontend"
178178
test-category: "frontend"
@@ -182,7 +182,7 @@ jobs:
182182
run-id: ${{ github.run_id }}
183183
run-attempt: ${{ github.run_attempt }}
184184
external-repo: "sgl-project/sglang"
185-
external-repo-ref: "v${{ needs.read_input.outputs.sglang-version }}"
185+
external-repo-ref: "v${{ needs.setup-variables.outputs.sglang-version }}"
186186
external-repo-path: "sglang_source"
187187
runs-on: '["codebuild-runner-${{ github.run_id }}-${{ github.run_attempt }}", "fleet:x86-g6exl-runner", "buildspec-override:true"]'
188188
concurrency-group: "${{ github.workflow }}-sglang-frontend-test"
@@ -208,7 +208,7 @@ jobs:
208208
if: |
209209
always() && !failure() && !cancelled() &&
210210
needs.set-test-environment.result == 'success'
211-
uses: ./.github/workflows/reusable/test-execution.yml
211+
uses: ./.github/workflows/reusable-test-execution.yml
212212
with:
213213
test-name: "sglang-sagemaker-endpoint"
214214
test-category: "integration"

0 commit comments

Comments
 (0)