Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move awslambda HttpResponseStream/streamifyResponse to the aws-sdk or its own package? #74

Open
mbklein opened this issue Jul 5, 2023 · 1 comment

Comments

@mbklein
Copy link

mbklein commented Jul 5, 2023

The fact that streamifyResponse and HttpResponseStream are only available embedded in the runtime makes it difficult to write simple, coherent unit tests for streaming lambda handlers. There's been at least one good attempt to create a wrapper to support easy testing, but it's not completely interface compatible (lacking, for example, the HttpResponseStream.from(underlyingStream, prelude) method) and it seems wasteful to rewrite/repackage code that's already written just to unbundle it from the rest of the NodeJS runtime.

@sladg
Copy link

sladg commented Sep 11, 2023

Agreed. Having hard time getting any typings and proper tests. At the same time, it seems like it's still under development and we are experiencing changes in behaviour multiple times a week for a past month. Any more details, examples, etc. would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants