Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should images ship with docker-credential-ecr-login pre-installed and configured? #743

Open
moltar opened this issue Sep 25, 2024 · 2 comments

Comments

@moltar
Copy link

moltar commented Sep 25, 2024

https://github.com/awslabs/amazon-ecr-credential-helper

It seems like a massive improvement over the classic:

aws ecr get-login-password --region=foo | \
  docker login --username AWS --password-stdin repository-uri
@jplock
Copy link

jplock commented Oct 3, 2024

It looks like the package is already included but needs to be configured.

@moltar
Copy link
Author

moltar commented Oct 3, 2024

Hm, that's interesting because I don't see it on the aws/codebuild/standard:7.0 image:

#2 ERROR: error getting credentials - err: exec: "docker-credential-ecr-login": executable file not found in $PATH, out: ``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants