Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid encoding MariaDB connection properties #1237

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix: avoid encoding MariaDB connection properties #1237

merged 3 commits into from
Jan 7, 2025

Conversation

aaron-congo
Copy link
Contributor

Description

  • fixes Undesired URL encoding of connection property #1222
  • before these changes, we encoded the property values passed to the buildUrl function. This function is only actually called when using a MariaDB data source. We do not encode MySQL or Postgres driver/datasource connections, and we do not encode MariaDB driver connections. Encoding the property values for MariaDB changes the intended values for the properties and can cause connection failures (see the linked issue above). I believe this encoding was originally intended to be used with MySQL and/or Postgres, but did not end up being used in those scenarios and isn't required for them either. This PR removes the call to encode the property values.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@aaron-congo aaron-congo merged commit 35d7088 into main Jan 7, 2025
6 checks passed
@aaron-congo aaron-congo deleted the remove-encoding branch January 7, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenc-bq karenc-bq karenc-bq approved these changes

@sergiyvamz sergiyvamz sergiyvamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undesired URL encoding of connection property
3 participants
@aaron-congo @karenc-bq @sergiyvamz