Update to ACK runtime v0.41.0, code-generator v0.41.0 (#285)

### Update to ACK runtime `v0.41.0`, code-generator `v0.41.0` ---------- * ACK code-generator `v0.41.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.41.0) * ACK runtime `v0.41.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.41.0) ---------- NOTE: This PR increments the release version of service controller from `v1.2.13` to `v1.2.14` Once this PR is merged, release `v1.2.14` will be automatically created for `sagemaker-controller` **Please close this PR, if you do not want the new patch release for `sagemaker-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building sagemaker-controller ==== Copying common custom resource definitions into sagemaker Building Kubernetes API objects for sagemaker Generating deepcopy code for sagemaker Generating custom resource definitions for sagemaker Building service controller for sagemaker Generating RBAC manifests for sagemaker Running gofmt against generated code for sagemaker Updating additional GitHub repository maintenance files ==== building sagemaker-controller release artifacts ==== Building release artifacts for sagemaker-v1.2.14 Generating common custom resource definitions Generating custom resource definitions for sagemaker Generating RBAC manifests for sagemaker ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
aws-controllers-k8s · Jan 23, 2025 · 7cc17d3 · 7cc17d3
1 parent 68e13e5
commit 7cc17d3
Show file tree

Hide file tree

Showing 110 changed files with 635 additions and 1,780 deletions.
diff --git a/OWNERS b/OWNERS
@@ -1,5 +1,4 @@
 # See the OWNERS docs at https://go.k8s.io/owners
 
 approvers:
-  - core-ack-team
-  - service-team
+  - core-ack-team
diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES
@@ -1,19 +1,16 @@
 # See the OWNERS docs at https://go.k8s.io/owners#owners_aliases
 
 aliases:
-  # Always allow the core ACK maintainers to have access to your repository
   core-ack-team:
-    - jaypipes
-    - mhausenblas
     - a-hilaly
-    - RedbackThomson
-    - vijtrip2
-    - jljaco
-  # TODO: Add your team members to your team controller alias
-  service-team:
-    - ananth102
-    - jsitu777
-    - surajkota
-    - ryansteakley
-    - rd-pong
-    - suryans-commit
+    - jlbutler
+    - michaelhtm
+    - TiberiuGC
+    - rushmash91
+  # emeritus-core-ack-team:
+  #   - jaypipes
+  #   - jljaco
+  #   - mhausenblas
+  #   - RedbackThomson
+  #   - vijtrip2
+  #   - ivelichkovich
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,8 +1,8 @@
 ack_generate_info:
-  build_date: "2024-08-29T17:06:56Z"
-  build_hash: f8f98563404066ac3340db0a049d2e530e5c51cc
-  go_version: go1.22.5
-  version: v0.38.1
+  build_date: "2025-01-23T02:33:10Z"
+  build_hash: 2442aa071c05fcdf54841e63abd5f91d1951e152
+  go_version: go1.23.5
+  version: v0.41.0
 api_directory_checksum: 476c2a15949ae95e3cefcc07b7eb39de6cd7548b
 api_version: v1alpha1
 aws_sdk_go_version: v1.50.15

diff --git a/config/controller/deployment.yaml b/config/controller/deployment.yaml
@@ -41,6 +41,8 @@ spec:
         - "$(LEADER_ELECTION_NAMESPACE)"
         - --reconcile-default-max-concurrent-syncs
         - "$(RECONCILE_DEFAULT_MAX_CONCURRENT_SYNCS)"
+        - --feature-gates
+        - "$(FEATURE_GATES)"
         image: controller:latest
         name: controller
         ports:
@@ -76,6 +78,8 @@ spec:
           value: "ack-system"
         - name: "RECONCILE_DEFAULT_MAX_CONCURRENT_SYNCS"
           value: "1"
+        - name: "FEATURE_GATES"
+          value: ""
         securityContext:
           allowPrivilegeEscalation: false
           privileged: false

diff --git a/config/controller/kustomization.yaml b/config/controller/kustomization.yaml
@@ -6,4 +6,4 @@ kind: Kustomization
 images:
 - name: controller
   newName: public.ecr.aws/aws-controllers-k8s/sagemaker-controller
-  newTag: 1.2.13
+  newTag: 1.2.14
diff --git a/config/crd/bases/sagemaker.services.k8s.aws_apps.yaml b/config/crd/bases/sagemaker.services.k8s.aws_apps.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.16.2
   name: apps.sagemaker.services.k8s.aws
 spec:
   group: sagemaker.services.k8s.aws
@@ -57,7 +57,6 @@ spec:
                   The instance type and the Amazon Resource Name (ARN) of the SageMaker image
                   created on the instance.
 
-
                   The value of InstanceType passed as part of the ResourceSpec in the CreateApp
                   call overrides the value passed as part of the ResourceSpec configured for
                   the user profile or the domain. If InstanceType is not specified in any of
@@ -84,13 +83,11 @@ spec:
                     A tag object that consists of a key and an optional value, used to manage
                     metadata for SageMaker Amazon Web Services resources.
 
-
                     You can add tags to notebook instances, training jobs, hyperparameter tuning
                     jobs, batch transform jobs, models, labeling jobs, work teams, endpoint configurations,
                     and endpoints. For more information on adding tags to SageMaker resources,
                     see AddTags (https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AddTags.html).
 
-
                     For more information on adding metadata to your Amazon Web Services resources
                     with tagging, see Tagging Amazon Web Services resources (https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html).
                     For advice on best practices for managing Amazon Web Services resources with
@@ -129,7 +126,6 @@ spec:
                       when it has verified that an "adopted" resource (a resource where the
                       ARN annotation was set by the Kubernetes user on the CR) exists and
                       matches the supplied CR's Spec field values.
-                      TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
                       https://github.com/aws/aws-controllers-k8s/issues/270
                     type: string
                   ownerAccountID:

diff --git a/config/crd/bases/sagemaker.services.k8s.aws_dataqualityjobdefinitions.yaml b/config/crd/bases/sagemaker.services.k8s.aws_dataqualityjobdefinitions.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.16.2
   name: dataqualityjobdefinitions.sagemaker.services.k8s.aws
 spec:
   group: sagemaker.services.k8s.aws
@@ -208,13 +208,11 @@ spec:
                     A tag object that consists of a key and an optional value, used to manage
                     metadata for SageMaker Amazon Web Services resources.
 
-
                     You can add tags to notebook instances, training jobs, hyperparameter tuning
                     jobs, batch transform jobs, models, labeling jobs, work teams, endpoint configurations,
                     and endpoints. For more information on adding tags to SageMaker resources,
                     see AddTags (https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AddTags.html).
 
-
                     For more information on adding metadata to your Amazon Web Services resources
                     with tagging, see Tagging Amazon Web Services resources (https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html).
                     For advice on best practices for managing Amazon Web Services resources with
@@ -253,7 +251,6 @@ spec:
                       when it has verified that an "adopted" resource (a resource where the
                       ARN annotation was set by the Kubernetes user on the CR) exists and
                       matches the supplied CR's Spec field values.
-                      TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
                       https://github.com/aws/aws-controllers-k8s/issues/270
                     type: string
                   ownerAccountID:

diff --git a/config/crd/bases/sagemaker.services.k8s.aws_domains.yaml b/config/crd/bases/sagemaker.services.k8s.aws_domains.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.16.2
   name: domains.sagemaker.services.k8s.aws
 spec:
   group: sagemaker.services.k8s.aws
@@ -50,11 +50,9 @@ spec:
                 description: |-
                   Specifies the VPC used for non-EFS traffic. The default value is PublicInternetOnly.
 
-
                      * PublicInternetOnly - Non-EFS traffic is through a VPC managed by Amazon
                      SageMaker, which allows direct internet access
 
-
                      * VpcOnly - All traffic is through the specified VPC and subnets
                 type: string
               appSecurityGroupManagement:
@@ -74,7 +72,6 @@ spec:
                   The default settings to use to create a user profile when UserSettings isn't
                   specified in the call to the CreateUserProfile API.
 
-
                   SecurityGroups is aggregated when specified in both calls. For all other
                   settings in UserSettings, the values specified in CreateUserProfile take
                   precedence over those specified in CreateDomain.
@@ -83,7 +80,6 @@ spec:
                     description: |-
                       The Code Editor application settings.
 
-
                       For more information about Code Editor, see Get started with Code Editor
                       in Amazon SageMaker (https://docs.aws.amazon.com/sagemaker/latest/dg/code-editor.html).
                     properties:
@@ -381,21 +377,18 @@ spec:
                   value. Tag keys must be unique per resource. Tags are searchable using the
                   Search API.
 
-
                   Tags that you specify for the Domain are also added to all Apps that the
                   Domain launches.
                 items:
                   description: |-
                     A tag object that consists of a key and an optional value, used to manage
                     metadata for SageMaker Amazon Web Services resources.
 
-
                     You can add tags to notebook instances, training jobs, hyperparameter tuning
                     jobs, batch transform jobs, models, labeling jobs, work teams, endpoint configurations,
                     and endpoints. For more information on adding tags to SageMaker resources,
                     see AddTags (https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AddTags.html).
 
-
                     For more information on adding metadata to your Amazon Web Services resources
                     with tagging, see Tagging Amazon Web Services resources (https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html).
                     For advice on best practices for managing Amazon Web Services resources with
@@ -437,7 +430,6 @@ spec:
                       when it has verified that an "adopted" resource (a resource where the
                       ARN annotation was set by the Kubernetes user on the CR) exists and
                       matches the supplied CR's Spec field values.
-                      TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
                       https://github.com/aws/aws-controllers-k8s/issues/270
                     type: string
                   ownerAccountID:

diff --git a/config/crd/bases/sagemaker.services.k8s.aws_endpointconfigs.yaml b/config/crd/bases/sagemaker.services.k8s.aws_endpointconfigs.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.16.2
   name: endpointconfigs.sagemaker.services.k8s.aws
 spec:
   group: sagemaker.services.k8s.aws
@@ -135,7 +135,6 @@ spec:
                   to perform actions on your behalf. For more information, see SageMaker Roles
                   (https://docs.aws.amazon.com/sagemaker/latest/dg/sagemaker-roles.html).
 
-
                   To be able to pass this role to Amazon SageMaker, the caller of this action
                   must have the iam:PassRole permission.
                 type: string
@@ -145,28 +144,21 @@ spec:
                   key that SageMaker uses to encrypt data on the storage volume attached to
                   the ML compute instance that hosts the endpoint.
 
-
                   The KmsKeyId can be any of the following formats:
 
-
                      * Key ID: 1234abcd-12ab-34cd-56ef-1234567890ab
 
-
                      * Key ARN: arn:aws:kms:us-west-2:111122223333:key/1234abcd-12ab-34cd-56ef-1234567890ab
 
-
                      * Alias name: alias/ExampleAlias
 
-
                      * Alias name ARN: arn:aws:kms:us-west-2:111122223333:alias/ExampleAlias
 
-
                   The KMS key policy must grant permission to the IAM role that you specify
                   in your CreateEndpoint, UpdateEndpoint requests. For more information, refer
                   to the Amazon Web Services Key Management Service section Using Key Policies
                   in Amazon Web Services KMS (https://docs.aws.amazon.com/kms/latest/developerguide/key-policies.html)
 
-
                   Certain Nitro-based instances include local storage, dependent on the instance
                   type. Local storage volumes are encrypted using a hardware module on the
                   instance. You can't request a KmsKeyId when using an instance type with local
@@ -176,11 +168,9 @@ spec:
                   using any nitro-based instances with local storage, the call to CreateEndpointConfig
                   fails.
 
-
                   For a list of instance types that support local instance storage, see Instance
                   Store Volumes (https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/InstanceStorage.html#instance-store-volumes).
 
-
                   For more information about local instance storage encryption, see SSD Instance
                   Store Volumes (https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ssd-instance-store.html).
                 type: string
@@ -278,13 +268,11 @@ spec:
                     A tag object that consists of a key and an optional value, used to manage
                     metadata for SageMaker Amazon Web Services resources.
 
-
                     You can add tags to notebook instances, training jobs, hyperparameter tuning
                     jobs, batch transform jobs, models, labeling jobs, work teams, endpoint configurations,
                     and endpoints. For more information on adding tags to SageMaker resources,
                     see AddTags (https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AddTags.html).
 
-
                     For more information on adding metadata to your Amazon Web Services resources
                     with tagging, see Tagging Amazon Web Services resources (https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html).
                     For advice on best practices for managing Amazon Web Services resources with
@@ -334,7 +322,6 @@ spec:
                       when it has verified that an "adopted" resource (a resource where the
                       ARN annotation was set by the Kubernetes user on the CR) exists and
                       matches the supplied CR's Spec field values.
-                      TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
                       https://github.com/aws/aws-controllers-k8s/issues/270
                     type: string
                   ownerAccountID: