Skip to content

Commit

Permalink
Run Notebook test in specified regions (#214)
Browse files Browse the repository at this point in the history
* test script

* add list

* add else statment

* formatting

* add deletion markers for pipeline

* add comment and update marker

* remove flakey region

* use args
  • Loading branch information
ryansteakley authored Mar 16, 2023
1 parent d81e600 commit 7932215
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
11 changes: 10 additions & 1 deletion test/canary/scripts/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ function cleanup {
kubectl delete modelpackagegroups --all
kubectl delete notebookinstances --all
kubectl delete notebookinstancelifecycleconfig --all
kubectl delete pipelineexecutions --all
kubectl delete pipelines --all

print_controller_logs

Expand Down Expand Up @@ -85,5 +87,12 @@ pushd $E2E_DIR

# run tests
echo "Run Tests"
pytest -n 15 --dist loadfile --log-cli-level INFO -m canary
pytest_args=( -n 15 --dist loadfile --log-cli-level INFO )
if [[ $SERVICE_REGION =~ ^(eu-north-1|eu-west-3)$ ]]; then
# If select_regions_1 true we run the notebook_instance test
pytest_args+=(-m "canary or select_regions_1")
else
pytest_args+=(-m "canary")
pytest "${pytest_args[@]}"
fi
popd
2 changes: 1 addition & 1 deletion test/e2e/tests/test_notebook_instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def get_notebook_instance_resource_status(reference: k8s.CustomResourceReference
return resource["status"]["notebookInstanceStatus"]

@flaky(max_runs=2, min_passes=1)
@pytest.mark.canary
@pytest.mark.select_regions_1
@service_marker
class TestNotebookInstance:
def _wait_resource_notebook_status(
Expand Down

0 comments on commit 7932215

Please sign in to comment.